From ecfdbbf34efa0de42551cfd4dd32a70f5867eb44 Mon Sep 17 00:00:00 2001
From: Sang Le <sang@go1.com>
Date: Thu, 11 Apr 2024 14:12:11 +1000
Subject: [PATCH] Correct usage of secrets

---
 .github/workflows/go1-helm-deploy.yml | 8 ++++----
 go1-values-override.yaml              | 3 +--
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/go1-helm-deploy.yml b/.github/workflows/go1-helm-deploy.yml
index 78405f1d..8a2e0a01 100644
--- a/.github/workflows/go1-helm-deploy.yml
+++ b/.github/workflows/go1-helm-deploy.yml
@@ -10,11 +10,11 @@ on:
         description: 'Release tag from the previous workflow'
         required: true
 env:
-  KUBECONFIG_CONTENTS: secrets.KUBECONFIG_PRODUCTION_K8S_AU
+  KUBECONFIG_CONTENTS: ${{ secrets.KUBECONFIG_PRODUCTION_K8S_AU }}
   # require envs for safe-settings app https://github.com/github/safe-settings/blob/main-enterprise/docs/deploy.md
-  APP_ID: secrets.APP_ID
-  WEBHOOK_SECRET: secrets.WEBHOOK_SECRET
-  PRIVATE_KEY: secrets.PRIVATE_KEY
+  APP_ID: ${{ secrets.APP_ID }}
+  WEBHOOK_SECRET: ${{ secrets.WEBHOOK_SECRET }}
+  PRIVATE_KEY: ${{ secrets.PRIVATE_KEY }}
 jobs:
   deploy-to-aks:
     if: ${{ github.event.inputs.status == 'passed' }}
diff --git a/go1-values-override.yaml b/go1-values-override.yaml
index d5b868ee..a5e7bf21 100644
--- a/go1-values-override.yaml
+++ b/go1-values-override.yaml
@@ -1,5 +1,4 @@
-deploymentConfig:
-  {}
+deploymentConfig: {}
 
 ingress:
   enabled: true