From 61c8523de18f0c151c3115a3c77766fea95df878 Mon Sep 17 00:00:00 2001 From: Jens Langhammer Date: Sun, 14 Apr 2024 22:12:27 +0200 Subject: [PATCH] add tests Signed-off-by: Jens Langhammer --- authentik/core/tests/test_groups_api.py | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/authentik/core/tests/test_groups_api.py b/authentik/core/tests/test_groups_api.py index df9cc03ebca6..91b5b641375b 100644 --- a/authentik/core/tests/test_groups_api.py +++ b/authentik/core/tests/test_groups_api.py @@ -1,10 +1,11 @@ """Test Groups API""" from django.urls.base import reverse +from guardian.shortcuts import assign_perm from rest_framework.test import APITestCase from authentik.core.models import Group, User -from authentik.core.tests.utils import create_test_admin_user +from authentik.core.tests.utils import create_test_admin_user, create_test_user from authentik.lib.generators import generate_id @@ -12,13 +13,15 @@ class TestGroupsAPI(APITestCase): """Test Groups API""" def setUp(self) -> None: - self.admin = create_test_admin_user() + self.login_user = create_test_user() self.user = User.objects.create(username="test-user") def test_add_user(self): """Test add_user""" group = Group.objects.create(name=generate_id()) - self.client.force_login(self.admin) + assign_perm("authentik_core.add_user_to_group", self.login_user, group) + assign_perm("authentik_core.view_user", self.login_user) + self.client.force_login(self.login_user) res = self.client.post( reverse("authentik_api:group-add-user", kwargs={"pk": group.pk}), data={ @@ -32,7 +35,9 @@ def test_add_user(self): def test_add_user_404(self): """Test add_user""" group = Group.objects.create(name=generate_id()) - self.client.force_login(self.admin) + assign_perm("authentik_core.add_user_to_group", self.login_user, group) + assign_perm("authentik_core.view_user", self.login_user) + self.client.force_login(self.login_user) res = self.client.post( reverse("authentik_api:group-add-user", kwargs={"pk": group.pk}), data={ @@ -44,8 +49,10 @@ def test_add_user_404(self): def test_remove_user(self): """Test remove_user""" group = Group.objects.create(name=generate_id()) + assign_perm("authentik_core.remove_user_from_group", self.login_user, group) + assign_perm("authentik_core.view_user", self.login_user) group.users.add(self.user) - self.client.force_login(self.admin) + self.client.force_login(self.login_user) res = self.client.post( reverse("authentik_api:group-remove-user", kwargs={"pk": group.pk}), data={ @@ -59,8 +66,10 @@ def test_remove_user(self): def test_remove_user_404(self): """Test remove_user""" group = Group.objects.create(name=generate_id()) + assign_perm("authentik_core.remove_user_from_group", self.login_user, group) + assign_perm("authentik_core.view_user", self.login_user) group.users.add(self.user) - self.client.force_login(self.admin) + self.client.force_login(self.login_user) res = self.client.post( reverse("authentik_api:group-remove-user", kwargs={"pk": group.pk}), data={ @@ -72,11 +81,11 @@ def test_remove_user_404(self): def test_parent_self(self): """Test parent""" group = Group.objects.create(name=generate_id()) - self.client.force_login(self.admin) + self.login_user = create_test_admin_user() + self.client.force_login(self.login_user) res = self.client.patch( reverse("authentik_api:group-detail", kwargs={"pk": group.pk}), data={ - "pk": self.user.pk + 3, "parent": group.pk, }, )