Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection error not reported to sentry #288

Closed
valentin-krasontovitsch opened this issue Sep 7, 2017 · 1 comment
Closed

Connection error not reported to sentry #288

valentin-krasontovitsch opened this issue Sep 7, 2017 · 1 comment

Comments

@valentin-krasontovitsch
Copy link

I'm wondering if there is any reason for the following error not being handled by the error handlers.

https://github.com/gocardless/hutch/blob/db5e5f34c9da7818c044e0857c321ad8c2185b61/lib/hutch/cli.rb#L93

I would like to see for instance connection problems at start-up reported by sentry.

If there is no reason for using the error handlers, I would love to submit a merge request.
@michaelklishin
Copy link
Member

It's been around since #9, so since very early days. It makes sense to collect those errors. Unless anyone objects, I'd say go ahead and submit a PR. We can discuss the downsides of this change there.

valentin-krasontovitsch pushed a commit to valentin-krasontovitsch/hutch that referenced this issue Nov 8, 2017
Report connection errors to sentry
50bb000 
When the hutch runner fails due to a connection, authentication or worker
setup error, the exception is only logged.

With this change the exception is also reported to sentry, if sentry is
available.

Closes ruby-amqp#288
Closed
valentin-krasontovitsch pushed a commit to valentin-krasontovitsch/hutch that referenced this issue Nov 9, 2017
Report connection errors to sentry
f142774 
When the hutch runner fails due to a connection, authentication or worker
setup error, the exception is only logged.

With this change the exception is reported with all available error
handlers.

Closes ruby-amqp#288
valentin-krasontovitsch pushed a commit to valentin-krasontovitsch/hutch that referenced this issue Dec 5, 2017
Handle setup exceptions
0a897f2 
To handle setup exceptions, a method was added to each error handler.

Said method is subsequently called when setup of the client fails.

This is to ensure that a failed setup is not only logged, but also
reported to e.g. sentry.

Closes ruby-amqp#288
This was referenced Dec 5, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelklishin @valentin-krasontovitsch