Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: Add 2.4.0, use jruby-9.1.7.0; don't trap QUIT on JRuby since it's not supported #271

Merged
merged 3 commits into from
Jan 20, 2017

Conversation

olleolleolle
Copy link
Contributor

This PR

  • adds 2.4.0 to the build matrix
  • updates to latest JRuby

@michaelklishin
Copy link
Member

Looks like tests hang on JRuby now, presumably because SIGQUIT is not handled as it used to be.

@olleolleolle
Copy link
Contributor Author

@michaelklishin That message about SIGQUIT has been in JRuby a long time. Should Hutch change its tune about that signal?

@michaelklishin
Copy link
Member

@olleolleolle on JRuby only, I think so.

@olleolleolle
Copy link
Contributor Author

I was able to get the hang on QUIT with "Randomized with seed 60614".

@michaelklishin
Copy link
Member

@olleolleolle 👍 let's drop QUIT support on JRuby then.

@michaelklishin
Copy link
Member

By the way, we can do it in this very PR.

@michaelklishin michaelklishin self-assigned this Jan 20, 2017
@olleolleolle
Copy link
Contributor Author

@michaelklishin I'll see if I can get a fix on the thing, so that we don't... mess things up.

@olleolleolle
Copy link
Contributor Author

@michaelklishin I began by unwinding a loop, so I could be remove a weirdly-placed next.

@michaelklishin
Copy link
Member

@olleolleolle I'm not sure what you mean. But thank you.

@olleolleolle
Copy link
Contributor Author

@michaelklishin The next move would be to never mention the QUIT signal to JRuby in the implementation of Waiter, so that no warnings are spouted.

@michaelklishin
Copy link
Member

Makes sense, thank you!

@olleolleolle
Copy link
Contributor Author

olleolleolle commented Jan 20, 2017

Now, the test output of WaiterSpec on JRuby is

Hutch::Waiter
  ["TERM", "INT"]
    includes only things in Signal.list.keys
  .wait_until_signaled
    a TERM signal is received
      logs that hutch is stopping
    a INT signal is received
      logs that hutch is stopping

@olleolleolle
Copy link
Contributor Author

@olleolleolle
Copy link
Contributor Author

@michaelklishin I'm more interested in the next build, which included the "skip QUIT on JRuby".

@michaelklishin michaelklishin changed the title Travis: Add 2.4.0, use jruby-9.1.7.0 Travis: Add 2.4.0, use jruby-9.1.7.0; don't trap QUIT on JRuby since it's not supported Jan 20, 2017
@michaelklishin michaelklishin merged commit 0f43a94 into ruby-amqp:master Jan 20, 2017
@michaelklishin
Copy link
Member

@olleolleolle thank you!

@olleolleolle olleolleolle deleted the patch-2 branch January 20, 2017 17:38
@olleolleolle
Copy link
Contributor Author

@michaelklishin Happy weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants