-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis: Add 2.4.0, use jruby-9.1.7.0; don't trap QUIT on JRuby since it's not supported #271
Conversation
Looks like tests hang on JRuby now, presumably because |
@michaelklishin That message about SIGQUIT has been in JRuby a long time. Should Hutch change its tune about that signal? |
@olleolleolle on JRuby only, I think so. |
I was able to get the hang on QUIT with "Randomized with seed 60614". |
@olleolleolle 👍 let's drop |
By the way, we can do it in this very PR. |
@michaelklishin I'll see if I can get a fix on the thing, so that we don't... mess things up. |
@michaelklishin I began by unwinding a loop, so I could be remove a weirdly-placed |
@olleolleolle I'm not sure what you mean. But thank you. |
@michaelklishin The next move would be to never mention the QUIT signal to JRuby in the implementation of Waiter, so that no warnings are spouted. |
Makes sense, thank you! |
Now, the test output of WaiterSpec on JRuby is
|
@michaelklishin Can you kill this build? https://travis-ci.org/gocardless/hutch/jobs/193808578 |
@michaelklishin I'm more interested in the next build, which included the "skip QUIT on JRuby". |
@olleolleolle thank you! |
@michaelklishin Happy weekend! |
This PR