Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added filter for updating text when not enrolled in any course #2396

Merged
merged 6 commits into from
Apr 21, 2023

Conversation

actuallyakash
Copy link
Contributor

Description

Added a filter for updating text when the user is not enrolled in any course.

Fixes #2365

How has this been tested?

Manually.

Screenshots

A user can use the below filter to update text:

function custom_not_enrolled_text( $text ) {
    return __( 'Oops! Looks like you haven\'t signed up for any courses yet.', 'lifterlms' );
}
add_filter( 'lifterlms_not_enrolled_text', 'custom_not_enrolled_text' );

image

Types of changes

Bug Fix.

Checklist:

  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

@github-advanced-security
Copy link

You have successfully added a new ESLint configuration .github/workflows/ossar-analysis.yml:OSSAR-Scan. As part of the setup process, we have scanned this repository and found 93 existing alerts. Please check the repository Security tab to see all alerts.

Copy link
Contributor

@seothemes seothemes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@actuallyakash looks good, I would just add a docblock for the new filter (see comment)

Also need to run npm run dev changelog add -- -i to add the changelog entry

includes/functions/llms.functions.templates.dashboard.php Outdated Show resolved Hide resolved
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql-analysis.yml:analyze/language:javascript. As part of the setup process, we have scanned this repository and found 62 existing alerts. Please check the repository Security tab to see all alerts.

includes/functions/llms.functions.templates.dashboard.php Outdated Show resolved Hide resolved
includes/functions/llms.functions.templates.dashboard.php Outdated Show resolved Hide resolved
.changelogs/issue_2365.yml Outdated Show resolved Hide resolved
.changelogs/issue_2365.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@eri-trabiccolo eri-trabiccolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@actuallyakash
once fixed these minor things I think we're good to go <3

.changelogs/issue_2365-1.yml Outdated Show resolved Hide resolved
.changelogs/issue_2365.yml Outdated Show resolved Hide resolved
@eri-trabiccolo eri-trabiccolo mentioned this pull request Apr 7, 2023
Copy link
Collaborator

@eri-trabiccolo eri-trabiccolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eri-trabiccolo eri-trabiccolo added this to the 7.2 milestone Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants