Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete recommendation CR after its workload got removed. #271

Closed
yufeiyu opened this issue Apr 18, 2022 · 0 comments · Fixed by #307
Closed

Delete recommendation CR after its workload got removed. #271

yufeiyu opened this issue Apr 18, 2022 · 0 comments · Fixed by #307
Assignees
@qmhu
Labels
kind/bug Something isn't working

Comments

@yufeiyu
Copy link
Contributor

yufeiyu commented Apr 18, 2022

Describe the bug
After a workload getting removed, its recommendation still exists.

Reproduce steps
Create a recommendation CR.
Delete the workload.
The recommendation is still there.

Expected behavior
The recommendation is deleted once its workload got removed.

Screenshots

Environment (please complete the following information):

  • K8S Version: [e.g. 1.19]
  • Crane Version: [e.g. 0.1.0]
  • Browser [e.g. chrome, safari]
@yufeiyu yufeiyu added the kind/bug Something isn't working label Apr 18, 2022
@qmhu qmhu self-assigned this May 17, 2022
@qmhu qmhu linked a pull request May 17, 2022 that will close this issue
feat(analytics): Analytics refactor #307
Merged
@qmhu qmhu closed this as completed May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qmhu qmhu

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(analytics): Analytics refactor qmhu/crane
2 participants
@yufeiyu @qmhu