diff --git a/pkg/metrics/metric_collector.go b/pkg/metrics/metric_collector.go index ae81fd981..3d1dd4e21 100644 --- a/pkg/metrics/metric_collector.go +++ b/pkg/metrics/metric_collector.go @@ -93,7 +93,7 @@ func (c *CraneMetricCollector) Collect(ch chan<- prometheus.Metric) { err := c.Get(context.TODO(), client.ObjectKey{Namespace: namespace, Name: tspName}, &tsp) if err != nil { - klog.Error("Failed to get tsp: %v", err) + klog.Errorf("Failed to get tsp: %v", err) return } metricListTsp := c.getMetricsTsp(&tsp) @@ -194,7 +194,7 @@ func (c *CraneMetricCollector) computePredictionMetric(tsp *predictionapi.TimeSe ts := time.Unix(v.Timestamp, 0) value, err := strconv.ParseFloat(v.Value, 64) if err != nil { - klog.Error(err, "Failed to parse sample value", "value", value) + klog.ErrorS(err, "Failed to parse sample value", "value", value) continue } //collect model metric of tsp for Prediction @@ -221,7 +221,7 @@ func (c *CraneMetricCollector) computePredictionMetric(tsp *predictionapi.TimeSe valueFloat, err := strconv.ParseFloat(v.Value, 32) if err != nil { - klog.Error(err, "Failed to parse sample value", "value", v.Value) + klog.ErrorS(err, "Failed to parse sample value", "value", v.Value) continue } @@ -232,7 +232,7 @@ func (c *CraneMetricCollector) computePredictionMetric(tsp *predictionapi.TimeSe } if !hasValidSample { - klog.Error("TimeSeries is outdated, ResourceIdentifier name %s", status.ResourceIdentifier) + klog.Errorf("TimeSeries is outdated, ResourceIdentifier name %s", status.ResourceIdentifier) return predictionMetrics } diff --git a/pkg/recommendation/recommender/resource/registry.go b/pkg/recommendation/recommender/resource/registry.go index baecbe866..6dfec2a1c 100644 --- a/pkg/recommendation/recommender/resource/registry.go +++ b/pkg/recommendation/recommender/resource/registry.go @@ -92,11 +92,11 @@ func NewResourceRecommender(recommender apis.Recommender, recommendationRule ana if err != nil { return nil, err } - specificationCofig, exists := recommender.Config["specification-config"] + specificationConfig, exists := recommender.Config["specification-config"] if !exists { - specificationCofig = DefaultSpecs + specificationConfig = DefaultSpecs } - specifications, err := GetResourceSpecifications(specificationCofig) + specifications, err := GetResourceSpecifications(specificationConfig) if err != nil { return nil, err }