Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISNBAT use the CoBlocks buttons block in Gutenberg 7.2.0 #1235

Closed
3 of 4 tasks
mmtr opened this issue Jan 6, 2020 · 1 comment · Fixed by #1241
Closed
3 of 4 tasks

ISNBAT use the CoBlocks buttons block in Gutenberg 7.2.0 #1235

mmtr opened this issue Jan 6, 2020 · 1 comment · Fixed by #1241
Labels
[Type] Bug Something that is not working as expected
Milestone

Comments

@mmtr
Copy link
Contributor

mmtr commented Jan 6, 2020

Describe the bug
The Buttons block from CoBlocks does not work when using the incoming Gutenberg 7.2.0. It might be related to the addition of a similar Buttons block introduced in Gutenberg 7.2.0 (WordPress/gutenberg#17352).

To Reproduce

  1. Download, install and activate Gutenberg 7.2.0 RC
  2. Insert a Buttons block from CoBlocks.
  3. Buttons are in different lines. Neither text nor URLs can be entered.

Screenshots

Gutenberg 7.2.0 RC Gutenberg 7.1.0
Screenshot 2020-01-06 at 17 01 19 Screenshot 2020-01-06 at 17 01 39

Expected behavior

Not sure, but there are several options:

  • Deprecate the CoBlocks Buttons block in favor of the new one from Core.
  • Rename the CoBlocks Buttons block so there are no 2 blocks with the same name.
  • If CoBlocks Buttons block remain active, it should behave like before (buttons are in the same line, and text or URLs can be entered).

Isolating the problem:

  • This bug happens with no other plugins activated
  • This bug happens with a default WordPress theme active
  • This bug happens without the Gutenberg plugin active
  • I can reproduce this bug consistently using the steps above

WordPress Version
5.3.2

Gutenberg Version
7.2.0 RC

@richtabor
Copy link
Contributor

Yea we definitely would like to deprecate our Buttons block for the version in 7.2.0, but there's not a clear way to deprecate blocks into other blocks just yet - but we're looking into it.

The ideal situation would be: if there's a core/buttons block registered, auto-transform the coblocks/buttons block into the core version.

@richtabor richtabor added [Block] Buttons [Type] Bug Something that is not working as expected labels Jan 7, 2020
@richtabor richtabor changed the title Buttons block broken in Gutenberg 7.2.0 ISNBAT use the CoBlocks buttons block in Gutenberg 7.2.0 Jan 10, 2020
@jrtashjian jrtashjian added this to the Next Release milestone Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something that is not working as expected
Projects
None yet
3 participants