Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further static safeguard against creating instances of types with no_constructor in Rust #629

Open
Tracked by #767
ghost opened this issue Nov 4, 2020 · 2 comments
Labels
breaking-change Issues and PRs that are breaking to fix/merge. c: export Component: export (mod export, derive) feature Adds functionality to the library
Milestone

Comments

@ghost
Copy link

ghost commented Nov 4, 2020

@Bromeon mentioned on Discord that it can be nice to introduce a DefaultConstructible trait for NativeClasses that don't have no_constructor, and use it as a bound for Instance::new and similar functions. Although this doesn't prevent the engine from trying to call the constructor anyway, it might be a nice-to-have on the Rust side.

This is a breaking change, and should be considered for the next minor version.

@ghost ghost added feature Adds functionality to the library breaking-change Issues and PRs that are breaking to fix/merge. labels Nov 4, 2020
@ghost ghost added this to the 0.10 milestone Nov 4, 2020
@Bromeon Bromeon added the c: export Component: export (mod export, derive) label Aug 25, 2021
@Bromeon
Copy link
Member

Bromeon commented Dec 8, 2021

Likely not going to happen until 0.10, moving to next milestone

@Bromeon Bromeon modified the milestones: v0.10.0, v0.11 Dec 8, 2021
@chitoyuu chitoyuu modified the milestones: unplanned, v0.12.0 Dec 6, 2022
@chitoyuu chitoyuu modified the milestones: v0.12.0, v0.13.0 Jan 29, 2023
@chitoyuu
Copy link
Contributor

Might be better suited for 0.13 to be done along with #808 and #714

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Issues and PRs that are breaking to fix/merge. c: export Component: export (mod export, derive) feature Adds functionality to the library
Projects
None yet
Development

No branches or pull requests

2 participants