Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an expression evaluator (REPL support with inspector sequent results) #4473

Closed
rohanrhu opened this issue Apr 30, 2022 · 8 comments · Fixed by godotengine/godot#97647
Closed
Assignees
Milestone

Comments

@rohanrhu
Copy link

Describe the project you are working on

Meow... I made an expression evaluator:

godotengine/godot#60134

image

Describe the problem or limitation you are having in your project

We need an expression evaluator in debugger, it is a very common need 😊

Describe the feature / enhancement and how it helps to overcome the problem or limitation

The evaluator has sequent results for expressions. It can get locals and members. When you click objects on results, it opens the object on inspector.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

Evaluator is using Expression class.

If this enhancement will not be used often, can it be worked around with a few lines of script?

Meow

Is there a reason why this should be core and not an add-on in the asset library?

Meow

@Calinou Calinou changed the title Expression Evaluater (REPL support with inspector sequent results) Add an expression evaluator (REPL support with inspector sequent results) Apr 30, 2022
@marcelb

This comment was marked as off-topic.

@visuallization

This comment was marked as off-topic.

@Calinou
Copy link
Member

Calinou commented Jan 12, 2023

@visuallization Please don't bump issues without contributing significant new information. Use the 👍 reaction button on the first post instead.

@The3DWizard
Copy link

Is there any active development going on for this issue? I see that it has been bumped to 4.3, but none of the dev snapshots of 4.3 mentions anything about debugging. Just curious about what the current state is.

@Calinou
Copy link
Member

Calinou commented Feb 23, 2024

Is there any active development going on for this issue? I see that it has been bumped to 4.3, but none of the dev snapshots of 4.3 mentions anything about debugging. Just curious about what the current state is.

The pull request needs to be rebased, but since 4.3 is entering its beta stage soon (where no large new features may be added), I doubt it'll make it for 4.3.

@rohanrhu
Copy link
Author

Is there any active development going on for this issue? I see that it has been bumped to 4.3, but none of the dev snapshots of 4.3 mentions anything about debugging. Just curious about what the current state is.

The pull request needs to be rebased, but since 4.3 is entering its beta stage soon (where no large new features may be added), I doubt it'll make it for 4.3.

Hi @Calinou, I made the latest requests but seems like (I'm not %100 sure though) a weird behavior is coming from inspector component's internal behavior; it is refreshing expression values when debugger's current stack frame is changed.

@johnmiko
Copy link

Sorry if this is a dumb question, this is available now? Or not until godot 4.4? Currently have godot 4.3 installed and would like to use this feature

@clayjohn
Copy link
Member

It's in 4.4, you can test it out in 4.4 dev 3 (https://godotengine.org/article/dev-snapshot-godot-4-4-dev-3/) or wait for the full 4.4 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment