You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A large project with more than 1000 files in a single directory/folder.
Describe the problem or limitation you are having in your project
Find in files functionality currently only searches for 1000 files per directory/folder.
Describe the feature / enhancement and how it helps to overcome the problem or limitation
By allowing find in files to search for more than 1000 files per directory/folder I will be able to use the Godot Editor to search my large project again.
Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams
Preferred Solution:
Modify find_in_files.cpp to allow for any number of files to be searched.
If the search is takes greater than X seconds (where X is for example 5 seconds), Godot Editor should ask the user via a pop-up or the search window if they would like to continue with the 'long running search'. Continue/Cancel.
Other Solution:
Add a setting in the Editor Settings to allow the user to change the 'find in files' time or file number limit.
Modify find_in_files.cpp to use the editor value instead of the currently hardcoded 1000 loop limit.
If this enhancement will not be used often, can it be worked around with a few lines of script?
No, this is a hardcoded limitation in find_in_files.cpp.
Is there a reason why this should be core and not an add-on in the asset library?
Searching the project codebase is essential especially for large project that contain more than 1000 files in a single directory/folder.
The text was updated successfully, but these errors were encountered:
sjharb
changed the title
Change Find in files to allow searching any number of files in a project, instead of the current limitation of 1000 files.
Change find in files to allow searching any number of files in a project, instead of the current limitation of 1000 files.
Jun 21, 2022
sjharb
changed the title
Change find in files to allow searching any number of files in a project, instead of the current limitation of 1000 files.
Change find in files to allow searching any number of files in a project, instead of the current limitation of 1000 files per folder.
Jun 21, 2022
sjharb
changed the title
Change find in files to allow searching any number of files in a project, instead of the current limitation of 1000 files per folder.
Change find in files to allow searching any number of files in a project, instead of the current limitation of 1000 files per directory/folder.
Jun 21, 2022
Calinou
changed the title
Change find in files to allow searching any number of files in a project, instead of the current limitation of 1000 files per directory/folder.
Change Find in Files to allow searching any number of files in a project, instead of the current limitation of 1,000 files per directory/folder
Jun 22, 2022
Describe the project you are working on
A large project with more than 1000 files in a single directory/folder.
Describe the problem or limitation you are having in your project
Find in files functionality currently only searches for 1000 files per directory/folder.
Describe the feature / enhancement and how it helps to overcome the problem or limitation
By allowing find in files to search for more than 1000 files per directory/folder I will be able to use the Godot Editor to search my large project again.
Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams
Preferred Solution:
Modify find_in_files.cpp to allow for any number of files to be searched.
If the search is takes greater than X seconds (where X is for example 5 seconds), Godot Editor should ask the user via a pop-up or the search window if they would like to continue with the 'long running search'. Continue/Cancel.
Other Solution:
Add a setting in the Editor Settings to allow the user to change the 'find in files' time or file number limit.
Modify find_in_files.cpp to use the editor value instead of the currently hardcoded 1000 loop limit.
If this enhancement will not be used often, can it be worked around with a few lines of script?
No, this is a hardcoded limitation in find_in_files.cpp.
Is there a reason why this should be core and not an add-on in the asset library?
Searching the project codebase is essential especially for large project that contain more than 1000 files in a single directory/folder.
The text was updated successfully, but these errors were encountered: