Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename symbol sometimes does not work properly #448

Closed
GianptDev opened this issue Jan 31, 2023 · 1 comment · Fixed by godotengine/godot#80973
Closed

Rename symbol sometimes does not work properly #448

GianptDev opened this issue Jan 31, 2023 · 1 comment · Fixed by godotengine/godot#80973
Labels
bug language server Issue is not originating from this extension, but from the LSP instead

Comments

@GianptDev
Copy link

Godot version

3.5.stable

VS Code version

1.74.2

Godot Tools VS Code extension version

1.3.1

System information

Windows 10

Issue description

Sometimes when I rename a variable, such as a constant or class name, anything that has a similar name but is not related to a variable get renamed too, renaming symbols does not take in account object properties and sometimes renaming will not work at all.

example:

class Thing extends Reference:
    var foo: bool = false; # Want to rename this to "different".

func bar () -> void:
    var new_thing: = Thing.new();
    var foo: bool = true; # this is renamed to "different".

    new_thing.foo = true; # This is untouched.

    for a in range(10): # renaming a to b does nothing.
        print(a);

Steps to reproduce

right click -> rename symbol

I tried classes and loops, those seem to have more problems.

@GianptDev GianptDev added the bug label Jan 31, 2023
@GianptDev GianptDev changed the title Rename symbol sometimes broke and rename stuff with similar name. Rename symbol sometimes does not work properly Jan 31, 2023
@atirut-w
Copy link

atirut-w commented Feb 1, 2023

This is a duplicate of #361, which should also have been closed since this issue is with Godot's LSP server. See godotengine/godot#65563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug language server Issue is not originating from this extension, but from the LSP instead
Projects
None yet
3 participants