Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BakedLightmap does not detect and use the GridMap models. #14687

Closed
kakoeimon opened this issue Dec 15, 2017 · 4 comments
Closed

BakedLightmap does not detect and use the GridMap models. #14687

kakoeimon opened this issue Dec 15, 2017 · 4 comments

Comments

@kakoeimon
Copy link

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Manjaro 64bit, Godot - Master build, NVidia GT540M

Issue description:

BakedLightmap in does not detect and use the GridMap models.

Steps to reproduce:
Import an object with generated uv2 for lightmap and make it in to a MeshLib, then create a GridMap and use it. Try to Bake. Nothing happens. It is like the Meshlib meshes are do not have UV2.

Link to minimal example project:
Bake_GI_Probe_Problems.zip

Test tsc in GridMap.tscn

@kakoeimon kakoeimon changed the title BakedLightmap in does not detect and use the GridMap models. BakedLightmap does not detect and use the GridMap models. Dec 15, 2017
@ghost ghost added this to the 3.0 milestone Dec 15, 2017
@kakoeimon
Copy link
Author

Reduz's answer on the issue on irc :

using gridmaps is not possible, because gridmaps are drawn using instancing. They will work with GIProbe, but not BakedLightmap
the only way to make them work would be an option to convert gridmaps to meshinstances

He told me to keep it open cause someone may want to work on this.
So I keep it open.

@reduz
Copy link
Member

reduz commented Dec 15, 2017

After discussing with @MarianoGnu , it may be possible to bake meshes transparently when running the lightmapper pass, so GridMap changes to meshes without you noticing and can add lighting.

@kakoeimon
Copy link
Author

I am closing this cause it was implemented.
e96c40f

@kakoeimon
Copy link
Author

Although this lead to another issue : #14795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants