Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glTF importer ignores KHR_materials_pbrSpecularGlossiness section #15059

Closed
seadra opened this issue Dec 26, 2017 · 7 comments · Fixed by #34193
Closed

glTF importer ignores KHR_materials_pbrSpecularGlossiness section #15059

seadra opened this issue Dec 26, 2017 · 7 comments · Fixed by #34193

Comments

@seadra
Copy link

seadra commented Dec 26, 2017

Godot version:
37aab45

OS/device including version:
Debian GNU/Linux

Issue description:
Some glTF files (example) store the texture information in KHR_materials_pbrSpecularGlossiness section. Right now, these are silently ignored but Godot can convert the specular-glossiness workflow numbers into metal-roughness numbers using the conversion mentioned in this document and make it look correct.

Steps to reproduce:
Import a glTF file with KHR_materials_pbrSpecularGlossiness section.

@seadra
Copy link
Author

seadra commented Dec 26, 2017

BTW, importing that glTF file with Gen Lightmaps option enabled crashes Godot editor.

@LinuxUserGD
Copy link
Contributor

LinuxUserGD commented Dec 26, 2017

Can you import the glTF file in Blender?
For instance https://github.com/ksons/gltf-blender-importer

@seadra
Copy link
Author

seadra commented Dec 27, 2017

Similar to the other glTF issue I created, this is also about the importer.

Godot importer for assets prepared in metallic-roughness work is OK. Godot doesn't seem to support specular-workflow, but there are such assets online, and Godot silently drops the specular-workflow textures. This is true regardless of the exporter you use.

@capnm
Copy link
Contributor

capnm commented Dec 27, 2017

godot3 uses the new metallic-roughness model, also it works as expected.
IMO the actual bug is, that godot doesn't fail to load the model in the xtensionsRequired case:

glft-mr-sg

@fire
Copy link
Member

fire commented Jan 9, 2020

Godot Engine isn't required to support KHR_materials_pbrSpecularGlossiness.

I agree.

Godot Engine should fail the file with an ERR_FILE_UNRECOGNIZED or FAILED with a message saying that Specular Glossiness is not supported.

https://github.com/KhronosGroup/glTF/tree/master/extensions/2.0/Khronos/KHR_materials_pbrSpecularGlossiness

https://github.com/KhronosGroup/glTF/tree/master/specification/2.0#specifying-extensions

@KoBeWi
Copy link
Member

KoBeWi commented Dec 10, 2020

Can anyone still reproduce this bug in Godot 3.2.3 or any later release?
The linked models died.

@fire
Copy link
Member

fire commented Dec 10, 2020

As far as I know this is still valid because my pr for it is unmerged.

If it helps I can give an example model.

https://sketchfab.com/3d-models/scifi-girl-v01-96340701c2ed4d37851c7d9109eee9c0#download This one has gloss spec.

@akien-mga akien-mga added this to the 4.0 milestone Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants