Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a suffix to MinGW build products to differentiate them from MSVC build products #17509

Closed
Calinou opened this issue Mar 14, 2018 · 5 comments

Comments

@Calinou
Copy link
Member

Calinou commented Mar 14, 2018

As noticed in #17194 (comment), MinGW build products should have a prefix in their name as to be differentiated from MSVC build products. This would prevent conflicts and build errors when using both compilers on the same system.

@bruvzg
Copy link
Member

bruvzg commented Mar 14, 2018

ARM Linux/Server builds also have conflicting suffixes ( .32 and .64, same as x86 builds ).

I would prefer to have something closer to standard GNU target triplets instead, like:

godot-tools-3.1.0-x86_64-pc-windows-gnu
godot-tools-3.1.0-x86_64-pc-windows-msvc
godot-server-3.1.0-aarch64-unknown-linux-gnu
...

@akien-mga
Copy link
Member

I agree with @bruvzg, it's time to up our game and be a bit more exhaustive.

@jahd2602
Copy link
Contributor

jahd2602 commented Jun 9, 2018

@bruvzg Macos won't run an executable with a dot in the name, can we replace the dots with underscore?

godot-tools-3_1_0-x86_64-pc-windows-gnu

@bruvzg
Copy link
Member

bruvzg commented Jun 9, 2018

Macos won't run an executable with a dot in the name, can we replace the dots with underscore?

Executables with dot in the name (in both executable and bundle names) should work fine on macOS, current build system produce executables with dot like godot.osx.tools.64 and godot.osx.opt.64 as well.

But there's a bug with loading exported pck when there's dot in the name - #15188.

@Calinou
Copy link
Member Author

Calinou commented Jun 3, 2020

Closing in favor of #24030, which is a better way to solve the issue at hand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants