Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PI is not defined in shaders #20726

Closed
isaacremnant opened this issue Aug 4, 2018 · 4 comments · Fixed by #48837
Closed

PI is not defined in shaders #20726

isaacremnant opened this issue Aug 4, 2018 · 4 comments · Fixed by #48837

Comments

@isaacremnant
Copy link
Contributor

Godot version: 3.1

PI is defined in GDscript but not in the shading language. Setting a uniform leads to an extra variable that could be modified through the inspector. Also, even if constants were available (#10577), some basic constants defined directly in the language would be useful. I'm new to shaders, so apologies if this is not desirable.

@CptPotato
Copy link
Contributor

Pi is often used in shaders so I think this is a good idea.

@creikey
Copy link
Contributor

creikey commented May 13, 2019

Along with TAU

@udit
Copy link

udit commented Sep 28, 2021

Can this be added to 3.3?

EDIT: nvm, I just saw it was added to 3.4 milestone

@clayjohn
Copy link
Member

@udit No, 3.3 is receiving bug fixes only. There is a PR open to add PI, TAU, and E to 3.4, but there is still ongoing discussion about whether breaking compatibility is worthwhile #52315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants