Update ingame default theme for control nodes

[Overblob]

Currently for every control node the theme defaults to the violet-ish one used before for Godot2

I think it could be nice to update the default colors, boxes, etc to match better Godot3's theme.

[Zylann]

I would note that these themes have two different uses, so making them the same for the sake of it is not really necessary IMO (not saying it shouldnt be done tho).

The editor theme is meant for the editor, and has been designed to be simple, modern and support the global coloring feature in its settings.

On the other hand, the default game theme rather shows each feature of widgets rather than trying to look like a classic modern app. For example, the editor theme is generally flat and has no window titlebars, but the game one does because it clearly shows the presence of that feature. The fact it is different also helps differenciating and shows how customizable it is.

The only main use case I see is when you make editor plugins, because very often the editor theme has different metrics than the default (although it should not matter if you design the UI by using exclusively anchoring rules instead of fixed placements).

I think there was a few comments along these lines in the past when the new theme got introduced, but I can't find them.

[volzhs]

there was discussion for it #8631 (comment)

[volzhs]

and there was a PR for it too #12718

[girng]

i like #12718 too because if the dev wants to use the editor theme they can just do that. however, this is just my opinion. it's not worth much, but i do agree with Zylann and been using the in-game theme for years

imo the buttons are way nicer and game-like (especially if you change the theme's button_normal.png to a nice color you like). they have the user experience of actually pressing a button. when the editor's buttons are more of a flat design. i know you said just control nodes, but you'd have to change everything or the theme would be wonky :O

[Overblob]

Thanks for your feedbacks!

@Zylann I completely understand your sayings.

IMO the default theme for controls is just a placeholder for prototyping. It is meant to be overridden when you skin your game GUI.
So keeping a different default theme for editor and game shouldn't really matter.

(And, if I'm not wrong the editor theme and default control theme were shared for Godot2.x) :p

In that sense, this issue would be more about homogeneity, because it feels a bit like the theme transition from Godot2 to Godot3 isn't completely finished yet.

[Calinou]

I think a good compromise would be to upgrade the default "game" theme to use StyleBoxFlat with a neutral gray color scheme, while staying independent of the editor theme. I'm not sure if the current editor theme could be used as a base though, due to how it's organized in the code.

[Calinou]

I started work on this for Godot 4.0: https://github.com/Calinou/godot/tree/improve-default-project-theme

The goal is to have a "neutral"-looking theme that goes well with the new default project DynamicFont. See the latest commit message in that branch for more information.

I can't give an ETA on when I'll open a pull request for it, but here's a sneak-peek of what it looks like currently:

The demo used for the screenshot above is the Control Gallery.