-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project becomes unopenable (in editor) if you set Message Queue Size to a low number. #33868
Comments
I think editor should be intelligent enough to check project settings sanity and that should be unit tested. Looks like good newbie onboarding work to do. |
This is pretty bad, there should just be a basic limit by default. Which shouldn't allow you to go this low. |
I think that's overly complicated, just limit what values you can use. |
Values like this can change with changes to editor code, changing some
constant every time is tedious and prone to error.
Adding simple test which would run at CI time to make sure this (and
other similar values) are correct is not too hard job.
Also using project values for editor might not be good idea at all as
requirements for these might be quite different.
Series of shortcuts like these often make people chose another
software due to high use costs.
…On Mon, Nov 25, 2019 at 3:35 PM RaTcHeT302 ***@***.***> wrote:
I think editor should be intelligent enough to check project settings sanity and that should be unit tested. Looks like good newbie onboarding work to do.
I think that's overly complicated, just limit what values you can use.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
On paper, it makes sense to use an hardcoded value in the editor, but remember that the editor can run tool scripts. If those tool scripts require an increased message queue size, you won't be able to benefit from value you increased in the Project Settings in the editor. Therefore, I think we should rather add a setting hint to prevent decreasing the value below the default. |
This is why I think editor could autotune queue size in tool mode which is just a few lines of code. |
Superseded by #35653. |
Godot version: v3.2.beta2
OS/device including version:
Intel Core i7-4790K CPU
16GB ram
Windows 8.1 64bit
Issue description:
This is probably not something someone should be doing anyway, so I'm sure this is a low priority issue.
When changing the value the editor tells you to save and restart to apply changes, do that and you can no longer open your project to even change it back. You must manually edit the
project.godot
file to change the setting so your project can be opened again.Steps to reproduce:
Godot editor will stay at the loading screen while the console endlessly floods with messages.
The text was updated successfully, but these errors were encountered: