Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project becomes unopenable (in editor) if you set Message Queue Size to a low number. #33868

Closed
rainlizard opened this issue Nov 25, 2019 · 7 comments

Comments

@rainlizard
Copy link
Contributor

Godot version: v3.2.beta2

OS/device including version:
Intel Core i7-4790K CPU
16GB ram
Windows 8.1 64bit

Issue description:
This is probably not something someone should be doing anyway, so I'm sure this is a low priority issue.
When changing the value the editor tells you to save and restart to apply changes, do that and you can no longer open your project to even change it back. You must manually edit the project.godot file to change the setting so your project can be opened again.

Steps to reproduce:

  1. Start new project
  2. Project Settings -> Memory -> Limits -> Message Queue -> Max Size Kb -> change to a low number.
  3. Click save and restart

Godot editor will stay at the loading screen while the console endlessly floods with messages.
loading screen
console
console2

@slapin
Copy link
Contributor

slapin commented Nov 25, 2019

I think editor should be intelligent enough to check project settings sanity and that should be unit tested. Looks like good newbie onboarding work to do.

@ghost
Copy link

ghost commented Nov 25, 2019

This is pretty bad, there should just be a basic limit by default. Which shouldn't allow you to go this low.

@ghost
Copy link

ghost commented Nov 25, 2019

I think editor should be intelligent enough to check project settings sanity and that should be unit tested. Looks like good newbie onboarding work to do.

I think that's overly complicated, just limit what values you can use.

@slapin
Copy link
Contributor

slapin commented Nov 25, 2019 via email

@Calinou
Copy link
Member

Calinou commented Nov 25, 2019

On paper, it makes sense to use an hardcoded value in the editor, but remember that the editor can run tool scripts. If those tool scripts require an increased message queue size, you won't be able to benefit from value you increased in the Project Settings in the editor.

Therefore, I think we should rather add a setting hint to prevent decreasing the value below the default.

@slapin
Copy link
Contributor

slapin commented Nov 25, 2019

This is why I think editor could autotune queue size in tool mode which is just a few lines of code.
The minimal thing which could be done - use constant for editor to run. In case of tool scripts, print meaningful error message. If scene can't be run with tools it is fine, leaving user clueless is not. Nice dialogue asking to reset value to default is a must as first step. Not being able to get perfect solution does not mean good one can't be found.

@akien-mga
Copy link
Member

Superseded by #35653.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants