Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong click behaviour (input event) on Android (Godot 3.2 RC 4) #35655

Closed
yalcin-ata opened this issue Jan 28, 2020 · 1 comment · Fixed by #35701
Closed

Wrong click behaviour (input event) on Android (Godot 3.2 RC 4) #35655

yalcin-ata opened this issue Jan 28, 2020 · 1 comment · Fixed by #35701

Comments

@yalcin-ata
Copy link

Godot version:
3.2 RC 4

OS/device including version:
Tested on Android 8.0.0 (Samsung S7 Edge [SM-G935F]) and Android 9 (Samsung S8 [SM-G950F])

Issue description:
(Description is related to sample project, see Minimal reproduction project for GitHub repository link)

With Godot 3.2 Beta 2 the click behaviour is as intented: clicking quickly on the buttons (from one to the next) turns them from green to blue (and back to green if clicked again).

With Godot 3.2 RC 4 the click behaviour is buggy: clicking quickly on the buttons (from one to the next) almost every click turns the previously clicked button (which was blue) to green again.

Steps to reproduce:

  • Start the app on an Android device

  • you should see 5 green "buttons"

  • click the first, then quickly click the second, the third, ...

  • green color turns to blue (and blue color turns to green)

  • With Godot 3.2 Beta 2 this works correct (no matter how quick the next buttons are clicked)

  • With Godot 3.2 RC 4 this is buggy (previously selected button changes its color if next button is clicked quickly)

Minimal reproduction project:
https://github.com/mrcrb/Godot-3.2-Android-Click-Bug

@akien-mga
Copy link
Member

I can confirm the regression on my Xiaomi Pocophone F1.

I tested intermediate versions between 3.2 beta 2 and RC 4:

This is likely a regression from #33630, CC @AlexHolly. It likely handles this rapid presses as double tap events, even though they're not pressing the same approximate location.
Can we configure the threshold for what should be a double tap? CC @m4gr3d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants