Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation Player Track Editor not zoomable with Trackpad #38237

Open
sean256 opened this issue Apr 26, 2020 · 17 comments
Open

Animation Player Track Editor not zoomable with Trackpad #38237

sean256 opened this issue Apr 26, 2020 · 17 comments

Comments

@sean256
Copy link

sean256 commented Apr 26, 2020

Godot version:
3.2.1 stable

OS/device including version:
macOS 10.15.4
Magic Trackpad 2

Issue description:
Using the trackpad I am unable to zoom/scale the Animation Player Track editor for bezier curves

Steps to reproduce:
Use a trackpad and try your best to zoom the bezier track editor. With a mouse you would use the mouse wheel while hovering over the track area, yet with a track pad the scroll gesture does nothing, neither does any gesture that I can think of trying.

Minimal reproduction project:
Not project specific, it's an editor thing

Screen Shot 2020-04-26 at 10 38 31 AM

@KoBeWi
Copy link
Member

KoBeWi commented Apr 26, 2020

I checked with my regular laptop touchpad and zooming works fine. Can you test in other areas, e.g. 2D editor?

@sean256
Copy link
Author

sean256 commented Apr 26, 2020

@KoBeWi It works in the 2D editor. Are you using a Mac trackpad?

@sean256
Copy link
Author

sean256 commented Apr 26, 2020

@KoBeWi I should clarify, the gesture to zoom in the 2D editor is different, it's the "pinch and zoom" thing. 2 fingers scrolling in the 2D editor does pan, which is expected.

@KoBeWi
Copy link
Member

KoBeWi commented Apr 26, 2020

Are you using a Mac trackpad?

No, I have Asus.

I should clarify, the gesture to zoom in the 2D editor is different, it's the "pinch and zoom" thing

Yes, and it works in both editors for me. Although in the Bezier Editor it works different from mouse wheel.
qtCFfA7jq9
Mouse wheel zooms the view, while pinch/zoom gesture scales the timeline.

@Calinou
Copy link
Member

Calinou commented Apr 26, 2020

I presume this is yet another issue related to high-precision scrolling on macOS.

@eduardonunesp
Copy link
Contributor

Is there any implementation before that using high precision scrolling, I can take a look to give a shot on this one

@dploeger
Copy link

I can confirm that. I can't even pan in the bezier editor with my trackpad. It happens both on the internal MacBook trackpad and the magic trackpad. When I use an external trackball (or mouse, I guess), it works.

In the animation editor itself, only vertical scrolling is possible.

@ArdaE
Copy link
Contributor

ArdaE commented Aug 8, 2020

Same problem here on a MacBook Pro trackpad. None of the following work in the Bezier curve editor:

  • Vertical scroll (two-finger vertical drag)
  • Horizontal scroll (two-finger horizontal drag)
  • Zoom in/out (two-finger pinch in/out)

Note that all of the above work fine in the text editor (for vertical panning, horizontal panning, and font-size adjustment, respectively).

External mouse wheel does work in the Bezier editor (achieves vertical zoom when used on its own, and horizontal zoom when used with the Command key). I haven't figured out a direct way to vertically pan using either the mouse or the trackpad, but because the zoom operations are centred about the mouse cursor, I'm able to indirectly pan by focusing the cursor at the right spots while I zoom in and out with the mouse wheel. Cumbersome, but works if one has a mouse with them.

@xaqbr
Copy link

xaqbr commented Jan 17, 2021

Has there been any fix yet for zooming in the bezier editor for MacBook trackpads?
Can there at least be a menu option for it in the meantime??

@Calinou
Copy link
Member

Calinou commented Jan 17, 2021

Has there been any fix yet for zooming in the bezier editor for MacBook trackpads?

Not yet.

Can there at least be a menu option for it in the meantime??

Maybe, but this needs to be requested in the Godot proposals repository instead of here 🙂

That said, I think it would be better to have keyboard shortcuts for zooming instead of menu options.

@iamjoeysox
Copy link

Any progress on this? I would be willing to help out if someone can point me in the right direction. Thanks!

@Calinou
Copy link
Member

Calinou commented Feb 18, 2021

Any progress on this? I would be willing to help out if someone can point me in the right direction. Thanks!

Nobody has started working on this feature, but keep in mind touchpad gestures are only implemented on macOS: #13139

Therefore, you won't be able to test this on other platforms.

@iamjoeysox
Copy link

Any progress on this? I would be willing to help out if someone can point me in the right direction. Thanks!

Nobody has started working on this feature, but keep in mind touchpad gestures are only implemented on macOS: #13139

Therefore, you won't be able to test this on other platforms.

That's okay I primarily use Mac anyways. I have been looking for something small to start with on learning how to contribute to the engine and this might be a great start. Will look into this when I get some free time. Thanks again!

@odbol
Copy link

odbol commented Mar 15, 2021

Just a suggestion: instead of trying to fix the trackpad, it might make more sense to add a separate affordance for changing the scale here, like using a keyboard or a button or something. Not everyone can use a mouse so it's good to have keyboard alternatives for accessibility.

@PabloNeirotti
Copy link

PabloNeirotti commented Jan 12, 2023

This affects macs Magic Mouse too. Touch gestures would be nice but supporting scrolling would be fine. Anything really! The code editor supports scrolling with Apple’s mouse.

@andzejsp
Copy link

andzejsp commented Sep 29, 2023

Windows 10 here, mouse. The issue is still in 4.1.1. I cant zoom the vertical axis. I want to be able to see values from 0 - 10 but by default there is only 0 - 50. doing CTRL + mouse wheel will zoom horizontally, doing CTRL + ALT + mouse wheel will do the same. No vertical zoom. In older versions in tutorials people was able to zoom vertically in bezier curve editor in animation player.

keyviz_2Y0DnLvFWv.mp4

EDIT:

Well it turns out if it aint workin, you gotta click inside the curve editor and it will work. See bellow. Very unintuitive

keyviz_xo9cK8BOCa.mp4

@artvel
Copy link

artvel commented Jan 3, 2024

Windows 11 + Mac M3 14.2.1 here. Scrolling vertical axis does work in 4.2.1.stable but you need to hold cntrl+alt while scrolling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests