CONNECT_REFERENCE_COUNTED requires two disconnects for a single connect

[chess123mate]

godot/core/object/object.cpp

Line 1368 in 2cbc0b6

if (slot->reference_count >= 0) {

The simple fix is to change slot->reference_count >= 0 to slot->reference_count > 0, except then if the first connection does not use CONNECT_REFERENCE_COUNTED and then a second connection does (this does not currently error), then you would need only a single disconnect despite connect having been called two times.

[Calinou]

@chess123mate Which Godot version did you experience this bug with?

Also, please upload a minimal reproduction project to make this easier to troubleshoot.

[chess123mate]

Version: Godot Engine v3.2.3.stable.official

The project I was experimenting with when I discovered this bug (it is fairly minimal): Connect.zip

[Shatur]

Can reproduce on 3.2.3 too:

extends Node2D


onready var _timer = $Timer


func _ready() -> void:
	_timer.connect("timeout", self, "_on_timeout", [], CONNECT_REFERENCE_COUNTED)
	_timer.connect("timeout", self, "_on_timeout", [], CONNECT_REFERENCE_COUNTED)
	_timer.connect("timeout", self, "_on_timeout", [], CONNECT_REFERENCE_COUNTED)
	_timer.disconnect("timeout", self, "_on_timeout")
	_timer.disconnect("timeout", self, "_on_timeout")
	_timer.disconnect("timeout", self, "_on_timeout")
#	_timer.disconnect("timeout", self, "_on_timeout") # Uncomment to prevent calling _on_timeout


func _on_timeout() -> void:
	print("Called!")