Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executing get_collision_polygons_count crashes Godot #51183

Closed
qarmin opened this issue Aug 2, 2021 · 0 comments · Fixed by #51185
Closed

Executing get_collision_polygons_count crashes Godot #51183

qarmin opened this issue Aug 2, 2021 · 0 comments · Fixed by #51185

Comments

@qarmin
Copy link
Contributor

qarmin commented Aug 2, 2021

Godot version

4.0.dev.custom_build. f2efa6f

System information

Ubuntu 21.04 - Nvidia GTX 970, Gnome shell 3.38 X11

Issue description

When executing

	var temp_variable = ClassDB.instantiate("TileData")
	temp_variable.set_terrain_set(40)
	temp_variable.set_peering_bit_terrain(-2, 46)
	temp_variable.get_collision_polygons_count(-40)

Godot crashes with backtrace

scene/resources/tile_set.cpp:3826:36: runtime error: index -2 out of bounds for type 'int [16]'
handle_crash: Program crashed with signal 11
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] godot4s() [0x2160680] (/mnt/Miecz/godot/platform/linuxbsd/crash_handler_linuxbsd.cpp:54)
[2] /lib/x86_64-linux-gnu/libc.so.6(+0x41040) [0x7fc5b2b10040] (??:0)
[3] CowData<TileData::PhysicsLayerTileData>::size() const (/mnt/Miecz/godot/./core/templates/cowdata.h:135)
[4] Vector<TileData::PhysicsLayerTileData>::size() const (/mnt/Miecz/godot/./core/templates/vector.h:87)
[5] TileData::get_collision_polygons_count(int) const (/mnt/Miecz/godot/scene/resources/tile_set.cpp:3704 (discriminator 7))
[6] void call_with_variant_args_retc_helper<__UnexistingClass, int, int, 0ul>(__UnexistingClass*, int (__UnexistingClass::*)(int) const, Variant const**, Variant&, Callable::CallError&, IndexSequence<0ul>) (/mnt/Miecz/godot/./core/variant/binder_common.h:695 (discriminator 4))
[7] void call_with_variant_args_retc_dv<__UnexistingClass, int, int>(__UnexistingClass*, int (__UnexistingClass::*)(int) const, Variant const**, int, Variant&, Callable::CallError&, Vector<Variant> const&) (/mnt/Miecz/godot/./core/variant/binder_common.h:453)
[8] MethodBindTRC<int, int>::call(Object*, Variant const**, int, Callable::CallError&) (/mnt/Miecz/godot/./core/object/method_bind.h:545)
[9] Object::call(StringName const&, Variant const**, int, Callable::CallError&) (/mnt/Miecz/godot/core/object/object.cpp:832 (discriminator 1))
[10] Variant::call(StringName const&, Variant const**, int, Variant&, Callable::CallError&) (/mnt/Miecz/godot/core/variant/variant_call.cpp:1017)
[11] GDScriptFunction::call(GDScriptInstance*, Variant const**, int, Callable::CallError&, GDScriptFunction::CallState*) (/mnt/Miecz/godot/modules/gdscript/gdscript_vm.cpp:1473)
[12] GDScriptInstance::call(StringName const&, Variant const**, int, Callable::CallError&) (/mnt/Miecz/godot/modules/gdscript/gdscript.cpp:1486)
[13] ScriptInstance::call(StringName const&, Variant const&, Variant const&, Variant const&, Variant const&, Variant const&, Variant const&, Variant const&, Variant const&) (/mnt/Miecz/godot/core/object/script_language.cpp:311)
[14] Node::_notification(int) (/mnt/Miecz/godot/scene/main/node.cpp:59)
[15] Node::_notificationv(int, bool) (/mnt/Miecz/godot/./scene/main/node.h:48 (discriminator 14))
[16] CanvasItem::_notificationv(int, bool) (/mnt/Miecz/godot/./scene/main/canvas_item.h:164 (discriminator 3))
[17] Node2D::_notificationv(int, bool) (/mnt/Miecz/godot/./scene/2d/node_2d.h:37 (discriminator 3))
[18] Object::notification(int, bool) (/mnt/Miecz/godot/core/object/object.cpp:843)
[19] SceneTree::_notify_group_pause(StringName const&, int) (/mnt/Miecz/godot/scene/main/scene_tree.cpp:851)
[20] SceneTree::process(double) (/mnt/Miecz/godot/scene/main/scene_tree.cpp:453 (discriminator 4))
[21] Main::iteration() (/mnt/Miecz/godot/main/main.cpp:2524)
[22] OS_LinuxBSD::run() (/mnt/Miecz/godot/platform/linuxbsd/os_linuxbsd.cpp:405)
[23] godot4s(main+0x40b) [0x215e151] (/mnt/Miecz/godot/platform/linuxbsd/godot_linuxbsd.cpp:60)
[24] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xd5) [0x7fc5b2af7565] (??:0)
[25] godot4s(_start+0x2e) [0x215dc8e] (??:?)

This example was found by fuzzer, so I don't recommend trying understand in what situation such code could be used in real project, because such situation probably doesn't exists.

Steps to reproduce

Above

Minimal reproduction project

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants