Behavior change in focus/hover styles in 3.4 breaks text color changes on focus

[jambonsupreme]

Godot version

v3.4.beta4.official.6a058cbf3

System information

Windows 10

Issue description

#47280 separated hover from focus, but I was relying on custom_colors/font_color_hover to higlight the selected menu item when moving the selection with the d-pad. This no longer works in 3.4. The selection moves around just fine, but with no highlighting. The addition of a custom_colors/font_color_focus property would help me to achieve the correct behaviour again, altough it would require a manual intervention.

Steps to reproduce

1. Add 2 or more buttons
2. Set "custom_colors/font_color_hover" to Color.red
3. Grab focus on one of the buttons
4. Move the selection with the keyboard / joystick arrows

In 3.3 the focused button is highlighted and the highlighting moves as you move the selection around, while in 3.4 the highlighting only appears while the mouse is hovering on the button.

Minimal reproduction project

font_color_hover.zip

[Calinou]

cc @jasonwinterpixel

[ghost]

I just wanted to quickly add what I already said in my duplicate bug report for completeness. Perhaps a new font color choice called Font Color Focus could be added which would act like the old hover changing the color both for keyboard focus and mouse focus. This would mirror the style choices which have a separate focus style and hover style. 👍

[YuriSizov]

@filipworksdev This is the same idea that we seem to have agreed upon between contributors to solve this regression, so feel free to open a PR if you want.

[akien-mga]

Fixed by #54264.

[ghost]

Hey guys. In the last Godot 4.4 rc2 editor menu items do not change color when mouse hovers over them but only the underline shows. I remember they used to highlight when mouse was over but I can't be sure. If that's new then it might be related to this change?

[YuriSizov]

@filipworksdev Can you show what you mean exactly?

[ghost]

@pycbouh Yes of course. See in the screen cap below my mouse is on Editor tool button but it doesn't light up, only the underline underneath it it does. Did it always behave like this? Unless of course it lights up but is incredibly faint white and looks no different than the regular editor tool tip button?

Edit: I think it might light up looking at it closer is just incredibly faint. I would imagine it should light up with the chosen highlight color that I have selected (in my case orange)

[YuriSizov]

Looks about the same for me in 3.3.4