Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor lags when selecting color for StyleBox #53087

Closed
floppyhammer opened this issue Sep 26, 2021 · 3 comments · Fixed by #53396
Closed

Editor lags when selecting color for StyleBox #53087

floppyhammer opened this issue Sep 26, 2021 · 3 comments · Fixed by #53396

Comments

@floppyhammer
Copy link
Contributor

Godot version

v3.4.beta5.official [dd0ee48]

System information

Windows 11, GLES3

Issue description

Editor lags when selecting color for StyleBox.

color_picker

Steps to reproduce

Open the reproduction project, click theme.tres in the FileSystem tab, change bg_color of a StyleBoxFlat.

Minimal reproduction project

StyleBoxColorTest.zip

@YuriSizov
Copy link
Contributor

YuriSizov commented Sep 26, 2021

Note that this doesn't happen in the latest 3.x version anymore because the StyleBox resource will now open in a new inspector instead of showing in a sub-inspector (regardless of how the editor is configured). This is ultimately a performance problem of the inspector with huge objects, which is made bigger by the fact that we have a theme editor now that also syncs up with the resource.

This is still a problem in master though.

@floppyhammer
Copy link
Contributor Author

No such an issue in 3.3. And it's not only lagging but also mouse input interruption which effectively makes the color selection process uncontrollable.

@YuriSizov
Copy link
Contributor

Yes, this is not so obvious in 3.3 and prior because basically nothing happens in the old theme editor. But the chokepoint is in the inspector nonetheless. You also don't see this in 3.4 with smaller theme resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants