Path/PathFollow (+Z) wrong orientation

[razcore-rad]

Godot version

v3.3.4.stable.official [faf3f88]

System information

Ubuntu 21.04

Issue description

The

Path
  - PathFollow

Setup orients on +Z, inverse from the convention. E.g. Vector3.FORWARD is Vector3(0, 0, -1) and look_at() orients on -Z, but Path/PathFollow orients on +Z.

See:

• godot/scene/3d/path_3d.cpp

  Line 120 in 5bc0e40

  Vector3 forward = c->interpolate_baked(o_next, cubic) - pos;

• godot/scene/3d/path_3d.cpp

  Line 128 in 5bc0e40

  forward = Vector3(0, 0, 1);

Steps to reproduce

1. Create the following tree:

Path
  - PathFollow

2. Set PathFollow -> Rotation Mode to Oriented.

---

Notice that +Z points forward on the curve. It should be -Z.

Minimal reproduction project

No response

[Calinou]

Fixing this will break compatibility with existing projects, so a new property needs to be added in 3.x to invert the Z direction. (We don't need such a property in master.)

[kubecz3k]

@Calinou since it's breaking compatibility maybe we should set milestone of this issue to 4.0?

[lukostello]

was just about to post this. I also find it odd that look_at Forward don't have a angle of 0 when using angle_to(). Makes me think what is currently RIGHT should be forward or angle 0 should be at the top. Probably wont happen because ages of convention. But if it were up to me I'd align those somehow. I'd probably make the trig functions follow the same convention as a clock. That way forward is 0 and the first quadrant is still positive for both sin and cos.