Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting Godot 3 project to Godot 4 doesn't properly handle transform tracks in animations #55292

Open
Tracked by #73960
stryker313 opened this issue Nov 24, 2021 · 7 comments · May be fixed by #84272
Open
Tracked by #73960

Comments

@stryker313
Copy link

Godot version

v4.0.dev.20211117.official

System information

Windows 10, gtx 1060, i5 4690k

Issue description

If you bring animations from Godot 3 to Godot 4, the tracks are wiped completely.
Whether you import the tracks manually via .tres, or .anim, or if you bring the whole anim player over

Animation tracks did get a rework, but there is no indication to the user that the tracks will be wiped upon loading them into Godot 4.

Steps to reproduce

Open these files in Godot 3, and you will see the tracks.
Open these same files in Godot 4, and the animation name will be there, but the tracks will be wiped, with no warning.

Minimal reproduction project

Godot4AnimationTransferBug.zip

@KoBeWi
Copy link
Member

KoBeWi commented Nov 24, 2021

We have many cases like this. E.g. opening 3.x UI scene in 4.0 will completely break the layout. When such thing happens, you can always close the scene without saving and manually upgrade the tscn.

I'd suggest running some project converter or at least making a backup before attempting to open old project.

@and-rad
Copy link
Contributor

and-rad commented Nov 27, 2021

This is a result of #53689. All of your animation tracks are transform tracks, which got replaced by individual loc/rot/scale tracks. They're not wiped, as you can see when you open the AnimationPlayer.tres file in a text editor, they're just not recognized. You could update the tracks manually or automatically with some regex. We could also try to get the project converter to handle these cases.

@akien-mga akien-mga changed the title Animation : Moving Animations from Godot 3 To 4 Wipes Tracks Without Warning Converting Godot 3 project to Godot 4 doesn't properly handle transform tracks in animations Nov 21, 2022
@akien-mga
Copy link
Member

Still valid as of 4.0 beta 5. The project conversion tool could possibly be enhanced to handle converting transform tracks.

@TokageItLab TokageItLab removed this from the 4.0 milestone Jan 14, 2023
@vladimir-sama
Copy link

Is this fixed now? Godot 4 beta 13

@mvanbaalen
Copy link

It doesn't look like it's fixed in 4.0 stable, and the converter also seems to be clearing. Opening my files outside of the editor to look at them just shows empty animations.

@Quimisagi
Copy link
Contributor

Will try to fix it.

@PLyczkowski
Copy link

Seems the problem still occurs in Godot_v4.2-beta4_win64
image
I'll be sure when I find the culprit (is there an easy way to find the culprit tscn?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants