Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme override checkbox is oblivious to undo #55455

Closed
KoBeWi opened this issue Nov 29, 2021 · 2 comments · Fixed by #60786 or #92207
Closed

Theme override checkbox is oblivious to undo #55455

KoBeWi opened this issue Nov 29, 2021 · 2 comments · Fixed by #60786 or #92207

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Nov 29, 2021

Godot version

3.4 / 4.0 03cfdf8

System information

W10

Issue description

The checkbox next to theme override properties takes effect when toggled, but the toggle isn't stored in the undo history in any way. When you add e.g. a color override, you can undo it, but the checkbox will still be pressed (until you re-select node). When you uncheck the checkbox to clear override, you won't be able to undo it.

Steps to reproduce

  1. Add e.g. Label
  2. Add override to font_color theme property
  3. Undo it
  4. Redo
  5. Uncheck the checkbox
  6. Undo / redo
  7. Weird things will happen

Minimal reproduction project

No response

@KoBeWi
Copy link
Member Author

KoBeWi commented Nov 30, 2021

@Calinou This also applies to master; I edited the version to be more clear.

@KoBeWi
Copy link
Member Author

KoBeWi commented Sep 16, 2022

Seems better than before, but it's still not fixed yet:
godot windows tools x86_64_CNAZW7gJQ0
You can't undo to pre-checkbox state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment