Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProjectSettings has_setting() does not work with feature tags overriden settings #57970

Closed
BimDav opened this issue Feb 11, 2022 · 1 comment · Fixed by #57972
Closed

ProjectSettings has_setting() does not work with feature tags overriden settings #57970

BimDav opened this issue Feb 11, 2022 · 1 comment · Fixed by #57972

Comments

@BimDav
Copy link
Contributor

BimDav commented Feb 11, 2022

Godot version

3.4.2-stable, 4.0 alpha 2

System information

Windows 10

Issue description

ProjectSettings' has_setting() method returns false even when the setting is overriden using feature tags. This is inconsistent with get_setting(), which can return a non null value even when has_setting() returns false.

Steps to reproduce

Override a setting using feature tags, and test it using has_setting()

Minimal reproduction project

has_setting.zip

@akien-mga
Copy link
Member

This is no longer "fixed" as #57972 is being reverted, but see my explanations there. I think this bug report misrepresented the problem, as the MRP is more complex than what is being discussed.

Here's a MRP which does not reproduce the described issue: feature_override_check.zip

So the issue is strictly plugin specific and related to the order of registration of the settings.

@akien-mga akien-mga added archived and removed bug labels Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants