Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rigidbody several regressions in godot 4.0 #59632

Closed
yosoyfreeman opened this issue Mar 28, 2022 · 8 comments · Fixed by #69657
Closed

Rigidbody several regressions in godot 4.0 #59632

yosoyfreeman opened this issue Mar 28, 2022 · 8 comments · Fixed by #69657

Comments

@yosoyfreeman
Copy link
Contributor

yosoyfreeman commented Mar 28, 2022

Godot version

4.0 alpha 3, alpha 4, alpha 5

System information

Linux mint

Issue description

Under certain circunstances, the body teleports upwards. Mostly noticiable when the body stop making contact with the floor and the wall. Is hard to replicate, but i made a project that i think it shows it well

RigidBody.Bug.mp4

.

Steps to reproduce

Create a platform with a collisionbody (Static, kinematic or Rigidbody dont alter the result) and a wall.
move a sphere towards the corner.

Minimal reproduction project

BugPhysics.zip

@Calinou
Copy link
Member

Calinou commented Mar 28, 2022

4.0 alpha 3

Please test this on 4.0alpha5. In the future, do not report issues on older alphas unless you've confirmed them on the latest alpha first. (If you do reproduce the issue in both alphas, mention it in the issue text.)

@yosoyfreeman
Copy link
Contributor Author

4.0 alpha 3

Please test this on 4.0alpha5. In the future, do not report issues on older alphas unless you've confirmed them on the latest alpha first. (If you do reproduce the issue in both alphas, mention it in the issue text.)

Sorry, i didn't knew there was a new alpha. I will check and tell you if is reproducible in the new one.

@yosoyfreeman
Copy link
Contributor Author

I can confirm that this bug is still reproducible in Godot alpha 5

@yosoyfreeman
Copy link
Contributor Author

Can confirm that this is still reproducible in the last Godot 4.0 alpha 9. Maybe it should be marked as a milestone cause right now the jumps are measurable in meters.

@Calinou
Copy link
Member

Calinou commented Jun 3, 2022

Can confirm that this is still reproducible in the last Godot 4.0 alpha 9. Maybe it should be marked as a milestone cause right now the jumps are measurable in meters.

This issue already has the 4.0 milestone 🙂

@yosoyfreeman
Copy link
Contributor Author

yosoyfreeman commented Jun 3, 2022 via email

@rburing
Copy link
Member

rburing commented Dec 6, 2022

Thanks for the clear minimal reproduction project. The bug in the MRP seems to be specific to a capsule shape with height == 2.0 * radius, so that it degenerates to a sphere, and GodotCapsuleShape3D::get_supports does not handle this case well, returning a segment of length zero instead of a point. I'll submit a PR to fix that (hence fixing the bug in the MRP). Can you reproduce this in any other cases?

@yosoyfreeman
Copy link
Contributor Author

Thanks for the clear minimal reproduction project. The bug in the MRP seems to be specific to a capsule shape with height == 2.0 * radius, so that it degenerates to a sphere, and GodotCapsuleShape3D::get_supports does not handle this case well, returning a segment of length zero instead of a point. I'll submit a PR to fix that (hence fixing the bug in the MRP). Can you reproduce this in any other cases?

Hi Rburing. Thanks for looking on it. I will try with other shapes and intersection angles in the last beta and post the results here if i notice it under other circumstances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants