-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exported vars not immediatelly updating for inherited scenes. #5997
Comments
retested today on e12b422 it's still valid |
I remember I recently changed this, if you change the exported value from the code, and the same value is used, it will be modified. |
Will recheck at the beginning of the next week |
The issue is still valid in ef08228 |
This is actually working, the problem is that you have a scene that contains the integer value as 3 (BaseGameObject) and by the time the instanced one is loaded, it will understand this as the actual value.. just for the fact that it's what it was saved. Even if you modify it. I will close this because I think it's quite a corner case and working it around (checking what is loaded instead of using what is saved) may result in another batch of inconsistencies. |
Well don't think it's a corner case, I very often have some main 'level' scene open at the time where I'm working with other smaller scenes. In a result subscenes that are added already to big 'Level' scene are transparently become out of sync. Usually it ends with some bugfix hunting couple days/weeks later. |
I off-course can be wrong and it's a minor use-case. Guess we can wait and see if more people will report something similar. |
Operating system or device - Godot version:
Ubuntu 16.04, f86176d commit
Issue description (what happened, and what was expected):
It's possible to accidentally modify exported values for inherited scenes in some scenarios. If you change exported var in base scene, and at the same time you have opened third party scene which is holding inherited scenes, then exported values for those instanced inherited scenes wont be updated.
Steps to reproduce:
exported var someValue = 3
5
and save it8. Change anything in WorldSceneLink to minimal example project (optional but very welcome):
Video that demonstrates the issue: https://youtu.be/6juDGlZo2Bw
Sample Project to make your own tests: (not sure if this is really needed since you still need to understand reproduction steps and perform some of them):
InheritPropertyNotUpdated.zip
I'm not 100% sure if this bug qualify for fix before 2.1 but I assume It might be good thing to be considered (since updating scenes with big number of inherited scenes is painfully). Also I think this bug is not present in 2.0 branch
The text was updated successfully, but these errors were encountered: