Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't Embed .pck when using rcedit to change ICO. #62109

Closed
RitleDev opened this issue Jun 16, 2022 · 5 comments
Closed

Can't Embed .pck when using rcedit to change ICO. #62109

RitleDev opened this issue Jun 16, 2022 · 5 comments
Labels

Comments

@RitleDev
Copy link

Godot version

3.4.4 Stable Official

System information

Windows 10, gtx 1660 super, GLES3, AMD Ryzen 5 3500x

Issue description

After exporting an embed .pck project that O set its icon using rcedit and setting the path to icon in the export option, I get an error when trying to open the exported file.

image

The error:

image

Is it possible to fix? Or do I have to choose between embed .pck or my custom icon?

Notes

  • I use Godot's 3.4.4 export template

Steps to reproduce

  1. I Set up an ICO file with these sizes. (256x256, 128x128, 64x64, 48×48, 32x32, 16x16)

  2. Followed to docs to reference rcedit, and change icon path in the export options.
    https://docs.godotengine.org/en/3.5/tutorials/export/changing_application_icon_for_windows.html

Minimal reproduction project

No response

@bruvzg
Copy link
Member

bruvzg commented Jun 16, 2022

It should be fixed in 3.5 and 4.0. For 3.4 you can work it around by adding an icon to the copy of template executable manually and setting it as a custom template in the export settings.

@akien-mga
Copy link
Member

Closing as per the above comment.

@anderlli0053
Copy link

It should be fixed in 3.5 and 4.0. For 3.4 you can work it around by adding an icon to the copy of template executable manually and setting it as a custom template in the export settings.

Do you maybe know which pull request does close / fix this issue? Can you paste the Issue ID?

@bruvzg
Copy link
Member

bruvzg commented Jun 16, 2022

Do you maybe know which pull request does close / fix this issue? Can you paste the Issue ID?

#60580 + #60752 (3.5)
#56093 + #60751 (4.0)

@anderlli0053
Copy link

Do you maybe know which pull request does close / fix this issue? Can you paste the Issue ID?

#60580 + #60752 (3.5) #56093 + #60751 (4.0)

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants