Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParticlesMaterial turbulence properties are missing default values #63798

Closed
fire-forge opened this issue Aug 1, 2022 · 2 comments · Fixed by #63815
Closed

ParticlesMaterial turbulence properties are missing default values #63798

fire-forge opened this issue Aug 1, 2022 · 2 comments · Fixed by #63815

Comments

@fire-forge
Copy link
Contributor

Godot version

v4.0.alpha.custom_build [98c1fb396]

System information

Windows 10

Issue description

The ParticlesMaterial turbulence properties are missing default values (except for turbulence_active). This means the revert button doesn't appear after changing the value in the inspector.

image

image

Steps to reproduce

Note: This must be done in a build from any commit after 9137ba7 (#55387).

  • Create a ParticlesMaterial
  • Open the "Turbulence" section
  • Change some properties
  • The revert button does not appear
    ...
  • Open the ParticlesMaterial documentation page
  • Navigate to the turbulence_* properties
  • See that there are no default values listed, except for turbulence_active

Minimal reproduction project

No response

@Calinou
Copy link
Member

Calinou commented Aug 2, 2022

cc @RPicster

@RPicster
Copy link
Contributor

RPicster commented Aug 2, 2022

I looked into it and the problem is that the properties are hidden when the turbulence is not active (And this is the default).
You can observe the same behaviour in the emission shape properties (changing the emission shape to e.g. sphere).

It seems that default values will only be picked up for properties that are not set to PROPERTY_USAGE_NONE at time of compilation. Eventually it would make sense to change this problem at the root? I would like to hear what the more experienced contributors think about this.

EDIT: By looking into other source files I found that the usage of PROPERTY_USAGE_NO_EDITOR is the correct way of handling this. Fixed by #63815

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants