Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected results when converting a project from 3 to 4 #63913

Open
Tracked by #73960
DeeJayLSP opened this issue Aug 4, 2022 · 2 comments
Open
Tracked by #73960

Unexpected results when converting a project from 3 to 4 #63913

DeeJayLSP opened this issue Aug 4, 2022 · 2 comments

Comments

@DeeJayLSP
Copy link
Contributor

DeeJayLSP commented Aug 4, 2022

Godot version

v4.0.alpha.mono.custom_build [426240f]

System information

Ubuntu 22.04

Issue description

In the current state, the project converter isn't able to convert some things like ResourceLoader.load_interactive().

It also doesn't correctly convert functions like move_and_slide() and intersect_ray(), resulting in some unexistent functions.

The project converted was TPS Demo.

Steps to reproduce

Download the latest release of the TPS Demo.

Convert it using --convert-3to4.

Run it on editor.

Minimal reproduction project

No response

@DeeJayLSP
Copy link
Contributor Author

When converting a 3.x intersect_ray() to 4.x, it should place its parameters into a PhysicsRayQueryParameters3D.create(<parameters>)

@KoBeWi
Copy link
Member

KoBeWi commented Aug 4, 2022

it should place its parameters into a PhysicsRayQueryParameters3D.create()

The order of arguments is different in create(). Mask comes before exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants