Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRACKER] TODOs in class documentation #65576

Open
4 of 6 tasks
RedMser opened this issue Sep 9, 2022 · 2 comments
Open
4 of 6 tasks

[TRACKER] TODOs in class documentation #65576

RedMser opened this issue Sep 9, 2022 · 2 comments

Comments

@RedMser
Copy link
Contributor

RedMser commented Sep 9, 2022

Godot version

master branch

System information

Issue description

I randomly stumbled upon one of these documentation TODOs, and I couldn't find an issue tracking these...

Current state of the class docs in master branch:

Steps to reproduce

Search *.xml documentation files for (TODO|FIXME) to find them.

Minimal reproduction project

No response

@atirut-w
Copy link
Contributor

I ran VSCode's search tool for "TODO" and there are 1385 results across 568 files and 245 results across 151 files for "FIXME". VSCode even hung up for a moment.

How the hell did it get this bad?

@akien-mga
Copy link
Member

@atirut-w This issue is about the class documentation so you should filter on *.xml only.

Other TODOs in code can be there for a variety of reasons, quite often as a hint for future self or future contributors that things could be improved in terms of code quality/performance. It's not particularly "bad" as you point it out, it's one aspect of code documentation to be able to point out what could be improved even if it's not critical to do it at a given point in time. In other cases, it does point at missing features / bugs that need to be solved, and those cases can be worth tracking in dedicated issues.

Finally, you should exclude thirdparty code when you search, we don't care about other projects' internal hints for future potential work.

$ rg "TODO" | wc -l
1374
$ rg "TODO" -g'!thirdparty' | wc -l
510

@RedMser RedMser changed the title Resolve TODOs in class documentation [TRACKER] TODOs in class documentation Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants