Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3-to-4 project converter changes instance of "Reference" in a comment to "RefCounted" #66061

Open
Tracked by #73960
daveTheOldCoder opened this issue Sep 18, 2022 · 0 comments · May be fixed by #66150
Open
Tracked by #73960

3-to-4 project converter changes instance of "Reference" in a comment to "RefCounted" #66061

daveTheOldCoder opened this issue Sep 18, 2022 · 0 comments · May be fixed by #66150
Labels
bug confirmed topic:editor
Milestone
4.x

Comments

@daveTheOldCoder
Copy link

Godot version

4.0.beta1

System information

Linux (Pop!_OS 20.04)

Issue description

3-to-4 project converter changes Instance of "Reference" in a comment to "RefCounted".

The converter should not change comments, since it doesn't know the reason for the comment or its context.

Steps to reproduce

Convert the minimal reproduction project attached below. Observe that the comment in node2d.gd is changed.

Minimal reproduction project

project_converter_3_to_4-bug2.zip
@daveTheOldCoder daveTheOldCoder changed the title 3-to-4 project converter changes Instance of "Reference" in a comment to "RefCounted" 3-to-4 project converter changes instance of "Reference" in a comment to "RefCounted" Sep 18, 2022
@gotnospirit gotnospirit linked a pull request Sep 20, 2022 that will close this issue
Open
@akien-mga akien-mga added this to the 4.0 milestone Sep 20, 2022
@Calinou Calinou mentioned this issue Oct 12, 2022
Closed
@Zireael07 Zireael07 mentioned this issue Oct 13, 2022
Closed
@Zireael07 Zireael07 mentioned this issue Jan 6, 2023
Closed
@akien-mga akien-mga modified the milestones: 4.0, 4.1 Feb 17, 2023
@KoBeWi KoBeWi mentioned this issue Feb 26, 2023
Open
@akien-mga akien-mga mentioned this issue Feb 27, 2023
Merged
@Maran23 Maran23 mentioned this issue Mar 1, 2023
Merged
@YuriSizov YuriSizov modified the milestones: 4.1, 4.2 Jun 22, 2023
@YuriSizov YuriSizov modified the milestones: 4.2, 4.x Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug confirmed topic:editor
Projects
None yet
Milestone
4.x
Development

Successfully merging a pull request may close this issue.

Prevent replacement in GDScript for literal string and comments gotnospirit/godot
4 participants
@Calinou @akien-mga @YuriSizov @daveTheOldCoder