Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting C# does NOT rename certain things #66321

Closed
Tracked by #73960
Coder2195Text opened this issue Sep 23, 2022 · 3 comments
Closed
Tracked by #73960

Converting C# does NOT rename certain things #66321

Coder2195Text opened this issue Sep 23, 2022 · 3 comments

Comments

@Coder2195Text
Copy link

Coder2195Text commented Sep 23, 2022

Godot version

Godot 4 Beta 1

System information

Ubuntu 22.02

Issue description

I tried Godot 4 Beta, and Im experiencing some issues. First, RectScale isnt renamed to Scale, and _PhysicsProcess(float delta), the delta needs to be changed to double. I see its beta, so most of dev is gonna bug fixes, not features, but can u fix this bug with the converter?

Not to mention net472 in csproj should be renamed to net6.0 when converting

Steps to reproduce

Convert https://github.com/coder2195text/tile-craft

Minimal reproduction project

https://github.com/coder2195text/tile-craft

@Calinou
Copy link
Member

Calinou commented Sep 24, 2022

First, RectScale isnt renamed to Scale

It should indeed be renamed, but is the converter even run on C# code?

and _PhysicsProcess(float delta), the delta needs to be changed to double

This is intended: #65313

We can resolve some of the casting inconveniences, but delta will remain a double to avoid precision issues in long-running projects (such as 24/7 dedicated servers).

@Coder2195Text
Copy link
Author

It should indeed be renamed, but is the converter even run on C# code?

Some of it gets renamed, like KimenaticBody --> CharacterBody
class also is partial class now

@akien-mga
Copy link
Member

RectScale is properly converted as of 4.0 RC 6.

The float/double issue is expected and should be handled manually by users.

@akien-mga akien-mga closed this as not planned Won't fix, can't repro, duplicate, stale Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants