Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsaved duplicate scripts seemingly get randomly created #68867

Closed
SaracenOne opened this issue Nov 19, 2022 · 5 comments
Closed

Unsaved duplicate scripts seemingly get randomly created #68867

SaracenOne opened this issue Nov 19, 2022 · 5 comments

Comments

@SaracenOne
Copy link
Member

Godot version

84c404f

System information

Windows 10, Vulkan, Intel® Core™ i7-8700K, Nvidia GTX 1080 (471.11)

Issue description

When working with GDScript files, sometimes they will randomly spawn unsaved broken duplicates upon saving:

godot windows editor dev x86_64_PJPWf1ma5u

Regression caused since merging of #67714

Steps to reproduce

Unknown as of yet, but occurs frequently and may be triggered by having errors in your scripts

Minimal reproduction project

N/A

@akien-mga
Copy link
Member

CC @adamscott

@akien-mga akien-mga added this to the 4.0 milestone Nov 19, 2022
@adamscott
Copy link
Member

adamscott commented Nov 19, 2022

Maybe fixed by #68872. Can you see if it happens still? #68872 reduces the number of errors, but does not fix the unsaved duplicate scripts issue.

@dalexeev
Copy link
Member

dalexeev commented Nov 19, 2022

Regression caused since merging of #67714

I noticed the bug before merging #67714, for example when renaming/moving a script. (Although after #67714 the bug began to happen much more often.)

@dmaz
Copy link
Contributor

dmaz commented Nov 21, 2022

I've seen this a couple times when I click a script icon from an instanced scene in the Scene tree. It seems I may have "fixed" my issue by "detatching" the script and reattaching it back.

I wonder if it has to do with the script uids still not working as well as they use to (there are a couple tickets I can ref if needed). for me, every time godot opens my project, many of the scenes complain about not finding resources by UID and loads them by name (even though they are correct) and then generates new UIDs. I wonder if that can cause some of these to get out of sync?

@SaracenOne
Copy link
Member Author

From my subsequent tests after the updates, I haven't noticed the particular initial issue anymore. It sounds like this problem may be deeper from other people's comments, but I'm going to close this for now. I'll reopen or create a new issue if I encounter anything similar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants