Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Project converter: draw_string specifying optional arguments are not updated to include new argument order #74412

Open
Tracked by #73960
nobuyukinyuu opened this issue Mar 5, 2023 · 0 comments

Comments

@nobuyukinyuu
Copy link
Contributor

nobuyukinyuu commented Mar 5, 2023

Godot version

4.0 stable

System information

Windows 10

Issue description

modulate in draw_color has moved 3 arguments down to make room for arguments involving size, clipping and alignment. Since optional parameters can't be skipped in gdscript (godotengine/godot-proposals#902), calls to this function should implement default values which represent best effort metrics similar to 3.x's default font if the font specified derived from default, or the size specified for the original DynamicFont. This means that the default size might be something different than the current default of 16. Qualifying the font may be nontrivial.

Steps to reproduce

Migrate project from 3.x to 4.0

Minimal reproduction project

n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants