Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch Rename lets you rename to invalid name without error or warnings #76679

Closed
ajreckof opened this issue May 2, 2023 · 1 comment · Fixed by #76376
Closed

Batch Rename lets you rename to invalid name without error or warnings #76679

ajreckof opened this issue May 2, 2023 · 1 comment · Fixed by #76376

Comments

@ajreckof
Copy link
Member

ajreckof commented May 2, 2023

Godot version

4.1.dev (1becfea)

System information

MacOS 13.3 M1 Pro

Issue description

When you use batch rename you can ask him to rename to invalid node names. it won't raise any warning nor error it will just rename to a valid node names without informing you of the change. For comparison with simple renames this is shown as warning
Capture d’écran 2023-05-02 à 21 49 47

Steps to reproduce

  1. create a root Node and two Node children
  2. select the two children
  3. Batch rename the e to %
  4. See that childrens have been renamed to Nod_ and Nod_2 without warning

Minimal reproduction project

N/A

@KoBeWi
Copy link
Member

KoBeWi commented May 2, 2023

We have a pretty standard way to validate and inform about errors. Create New Scene dialog for example:
image
Something like this could be implemented for the batch rename dialog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants