Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan Mobile: Baking lightmaps on Android causes the editor to crash #77001

Open
Tracked by #56033
Booklight12 opened this issue May 12, 2023 · 4 comments
Open
Tracked by #56033

Comments

@Booklight12
Copy link

Booklight12 commented May 12, 2023

Godot version

4.02

System information

Android, Guet 8100

Issue description

As the title suggests, light baking is not stable on Android and will generate a lot of errors, which may cause the device to restart if the project is too complicated. I suspect it may have something to do with a drive or memory leak. (Please run the upload example on Android, then click gi's Light Bake button several times, you will see a lot of errors, note that doing this on a phone with less than 6GB of RAM may cause a reboot!!)

Steps to reproduce

null

Minimal reproduction project

this

Bugsquad edit:
exc.zip (MRP uploaded directly here, to prevent link rot)

@Booklight12
Copy link
Author

Screenshot_2023-05-12-20-03-46-828_org godotengine editor v4

@Booklight12
Copy link
Author

You can try adding a few more objects in your project and adding more complex shaders and see what happens (note that it may cause the device to reboot!!).

@Calinou
Copy link
Member

Calinou commented May 12, 2023

Compute shaders are pretty broken on mobile due to bugs in graphics drivers which we have no control over. However, compute shaders are required to use the GPU-based lightmapper in Godot 4.x (unlike Godot 3.x which uses a CPU-based lightmapper). We should probably disallow baking lightmaps in the mobile editor as it will generally not work in practice.

I guess this is another use case for godotengine/godot-proposals#3921, although baking lightmaps on a mobile device is expected to be very slow in any case (regardless if you use the CPU or GPU to do so).

@Calinou Calinou changed the title The Android light baking caused the phone to reboot Vulkan Mobile: Baking lightmaps on Android causes the editor to crash May 12, 2023
@Saul2022
Copy link

Can't reproduce in godot 4.3 beta 3, because it unable to bake lightmqp with this error, it happens in both forwerd + and mobile, though doing so in pc works.

scene/3d/lightmap_gi.cpp:744 - Condition "lightmapper.is_null()" is true. Returning: BAKE_ERROR_NO_LIGHTMAPPER

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants