Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: LightmapGI has incorrect indirect light probes when using static directional light #77356

Closed
Tracked by #56033
jcostello opened this issue May 22, 2023 · 3 comments · Fixed by #82068
Closed
Tracked by #56033

Comments

@jcostello
Copy link
Contributor

Godot version

v4.1.dev.custom_build [437041a]

System information

Ubuntu with Nvidia 2060

Issue description

When baking static directional light, lightmap probes don't work as expected like with dynamic bake.

Dynamic Bake
Screenshot from 2023-05-22 12-43-42

Static Bake
Screenshot from 2023-05-22 12-44-52

Steps to reproduce

Use MRP

Bake directional light as dynamic
Disable and enable sphere mesh to apply probes lighting

Bake directional light as static
Disable and enable sphere mesh to apply probes lighting

See the same result as image above

Minimal reproduction project

lightmap.zip

@Calinou Calinou changed the title [LightmapGI] Incorrect indirect light probes when using static directional light Vulkan: LightmapGI has incorrect indirect light probes when using static directional light Jun 9, 2023
@atirut-w
Copy link
Contributor

Seems to still happen on v4.1.stable.official [9704596]. Here are screenshots with probe gizmos enabled:

Dynamic(default)
image

Static
image

This doesn't affect just directional lights either. I tested this with omni and spot lights and they are both affected:

image

@jcostello
Copy link
Contributor Author

#82068 Fixes the issue

@akien-mga akien-mga added this to the 4.2 milestone Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants