Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

history_changed events stop emitting when clicking the same inspector attribute twice. #79478

Closed
henriquelalves opened this issue Jul 14, 2023 · 0 comments · Fixed by #79484
Closed

Comments

@henriquelalves
Copy link
Contributor

henriquelalves commented Jul 14, 2023

Godot version

4.1 Stable

System information

MacBook Ventura 13.4

Issue description

Undo/Redo manager history_changed events stop being emitted when clicking on the same editor inspector property. This also stops creating Undo/Redo events, so "undo" actions stop working.

Steps to reproduce

The steps to reproduce is kind of finnicky, but I was able to reproduce it with relative easy using the "position" propert:

  • Click "Y" position and change it to any value; press Enter.
  • Click the "Y" position again and change it to any value; press Enter.
  • Click the "Y" position again (again), and change it to any value; press Enter.

On the third time changing the value, "history_changed" events stop being emitted. Checking the "History" tab, you'll see only the two events are logged (other changes in the position are not).

Minimal reproduction project

This can be reproduced in any project, but I'm attaching a project with an addon that logs a "history_changed" event on the console so you know when it stops being emitted.
HistoryIssue.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants