Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnimationTree: animation_started signal is always emitted twice #80118

Closed
Coxcopi opened this issue Aug 1, 2023 · 6 comments · Fixed by #80367
Closed

AnimationTree: animation_started signal is always emitted twice #80118

Coxcopi opened this issue Aug 1, 2023 · 6 comments · Fixed by #80367

Comments

@Coxcopi
Copy link

Coxcopi commented Aug 1, 2023

Godot version

v4.1.1.stable.official [bd6af8e]

System information

Godot v4.1.1.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 6GB (NVIDIA; 31.0.15.3179) - Intel(R) Core(TM) i5-8500 CPU @ 3.00GHz (6 Threads)

Issue description

When connecting the animation_started signal from an animation tree, the connected method is always called twice.
This only occurs with the animation_started signal, the animation_finished signal is only emitted once.

This unfortunately makes relying on the signal impossible.

Steps to reproduce

(See minimal production project)

  • Use animation_started.connect()
  • Print something out in the connected method (the example project prints the anim_name parameter)
  • method is called twice -> two prints in the console

Minimal reproduction project

anim_tree_signal_bug.zip

The animation tree travels to the 'move' animation when ui_accept is pressed (see anim_tree.gd) and has print statements inside the methods connected to both the animation_started and animation_finished signal.

@abmarnie
Copy link

I am still experiencing this in v4.2.0.stable.mono. If someone else would like to double check (or make an MRP for me 😄), that would be nice.

@krumplespiff
Copy link

I am still experiencing this in v4.2.0.stable.mono. If someone else would like to double check (or make an MRP for me 😄), that would be nice.

I can confirm I am having this issue in 4.2.1 stable. Very annoying because now I need to move every single signal emit and method call to my input commands (redundant) instead of having it linked to the animations

@CrayolaEater
Copy link
Contributor

me too

@valkyrienyanko
Copy link

valkyrienyanko commented Mar 14, 2024

Where is the new issue for this? I'm still experiencing this on v4.2.1.stable.mono.official [b09f793]

@oxeron
Copy link

oxeron commented May 26, 2024

I confirm I still have the issue in 4.2.2

@TheSofox
Copy link
Contributor

Was able to confirm in v4.2.1.stable.official [b09f793]
image

But when trying in latest ( v4.3.beta.custom_build [25ff130] ) it doesn't seem present:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants