Dragging an object does not respect selection.

[SkanerSoft]

Godot version

3.6 Beta 3

System information

Ubuntu 22

Issue description

When I drag an object from the file system of the engine, the selected object is ignored, it is added to the scene end.

In Godot 3.5.2, everything works correctly, when you drag an object, it becomes a child of the selected object.

This is how it worked before (3.5.2)

Peek.2023-08-19.23-47.mp4

This is how it works now (3.6)

Peek.2023-08-19.23-49.mp4

Steps to reproduce

Drag an object (in 3D, *.mesh) into the workspace from the engine's file system.

Minimal reproduction project

Does not trumpet, because works in any project.

[SkanerSoft]

Small addition: The problem is observed in all versions 3.6 (beta 1, 2, 3).

[matheusmdx]

Bisecting the issue leads to #55626, but after check the code is possible to see that is not a regression, but a behavior change, now you need to hold ctrl before drop the 3d object to have the same behavior, so this is most a documentation issue.

godot/editor/plugins/spatial_editor_plugin.cpp

Lines 4223 to 4240 in 1d7a417

	bool is_ctrl = Input::get_singleton()->is_key_pressed(KEY_CONTROL);
	selected_files.clear();
	Dictionary d = p_data;
	if (d.has("type") && String(d["type"]) == "files") {
	selected_files = d["files"];
	}
	List<Node *> selected_nodes = editor->get_editor_selection()->get_selected_node_list();
	Node *root_node = editor->get_edited_scene();
	if (selected_nodes.size() == 1) {
	Node *selected_node = selected_nodes[0];
	target_node = root_node;
	if (is_ctrl) {
	target_node = selected_node;
	} else if (is_shift && selected_node != root_node) {
	target_node = selected_node->get_parent();
	}

[SkanerSoft]

I tried this method and it solves this problem but creates another one. The snapping is completely lost and I can't position the new object in the right place.

test.mp4

[SkanerSoft]

I don’t quite understand the reasons to change long-standing functionality, instead of expanding it with use cases without changing basic things.

[Calinou]

Bisecting the issue leads to #55626, but after check the code is possible to see that is not a regression, but a behavior change, now you need to hold ctrl before drop the 3d object to have the same behavior, so this is most a documentation issue.

I think this is a regression, as the behavior is only supposed to change if there is no root node present in the current scene. There's no reason to change the behavior when there is already a root node present in the scene.

[SkanerSoft]

So, I tried using CTRL and dragging, but the convenience was greatly reduced because... CTRL enables snapping to the grid, you have to make a lot of movements to adjust positions. It is also very inconvenient that this differs in behavior from 3.5. Temporarily returning to 3.5.

[SkanerSoft]

We kindly ask you to return the previous behavior of dragging objects, or make it customizable. This behavior is unintuitive and differs from all versions of the engine. It became bad to use it. Also, CTRL does not allow you to position the object due to snapping to the grid.

[Calinou]

Bisecting the issue leads to #55626, but after check the code is possible to see that is not a regression, but a behavior change, now you need to hold ctrl before drop the 3d object to have the same behavior, so this is most a documentation issue.

That PR shouldn't be affecting non-root nodes in the scene. In other words, if you already have an existing node in the scene at the time of drag-and-dropping, the behavior should be the same as 3.5.

Therefore, it's a bug 🙂

[SkanerSoft]

3.6 B4, problem persists.