Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when closing the editor with an empty AnimationTree #82549

Closed
Chaosus opened this issue Sep 29, 2023 · 0 comments · Fixed by #82573
Closed

Crash when closing the editor with an empty AnimationTree #82549

Chaosus opened this issue Sep 29, 2023 · 0 comments · Fixed by #82573

Comments

@Chaosus
Copy link
Member

Chaosus commented Sep 29, 2023

Godot version

44e399e

System information

Windows 11

Issue description

The simple scene with a AnimationTree:

image0

cause Godot heap crash when the user close the editor with the following call stack:

	godot.windows.editor.x86_64.exe!_free_base(void * block) Line 105		C++godot.windows.editor.x86_64.exe!HashMap<StringName,Object::SignalData,HashMapHasherDefault,HashMapComparatorDefault<StringName>,DefaultTypedAllocator<HashMapElement<StringName,Object::SignalData>>>::~HashMap<StringName,Object::SignalData,HashMapHasherDefault,HashMapComparatorDefault<StringName>,DefaultTypedAllocator<HashMapElement<StringName,Object::SignalData>>>() Line 620	C++
 	godot.windows.editor.x86_64.exe!Object::`scalar deleting destructor'(unsigned int)	C++
 	[Inline Frame] godot.windows.editor.x86_64.exe!memdelete(AnimationPlayer * p_class) Line 109	C++
 	[Inline Frame] godot.windows.editor.x86_64.exe!AnimationPlayerEditorPlugin::{dtor}() Line 2207	C++
 	godot.windows.editor.x86_64.exe!AnimationPlayerEditorPlugin::`scalar deleting destructor'(unsigned int)	C++
 	[Inline Frame] godot.windows.editor.x86_64.exe!memdelete(Node *) Line 109	C++
 	godot.windows.editor.x86_64.exe!Node::_notification(int p_notification) Line 212	C++
 	[Inline Frame] godot.windows.editor.x86_64.exe!Node::_notificationv(int) Line 49	C++
 	godot.windows.editor.x86_64.exe!EditorNode::_notificationv(int p_notification, bool p_reversed) Line 119	C++
 	[Inline Frame] godot.windows.editor.x86_64.exe!Object::notification(int) Line 843	C++
 	[Inline Frame] godot.windows.editor.x86_64.exe!Object::_predelete() Line 198	C++
 	godot.windows.editor.x86_64.exe!predelete_handler(Object * p_object) Line 2027	C++
 	[Inline Frame] godot.windows.editor.x86_64.exe!memdelete(Node *) Line 105	C++
 	godot.windows.editor.x86_64.exe!Node::_notification(int p_notification) Line 212	C++
 	[Inline Frame] godot.windows.editor.x86_64.exe!Node::_notificationv(int) Line 49	C++
 	godot.windows.editor.x86_64.exe!Viewport::_notificationv(int p_notification, bool p_reversed) Line 95	C++
 	godot.windows.editor.x86_64.exe!Window::_notificationv(int p_notification, bool p_reversed) Line 45	C++
 	[Inline Frame] godot.windows.editor.x86_64.exe!Object::notification(int) Line 843	C++
 	[Inline Frame] godot.windows.editor.x86_64.exe!Object::_predelete() Line 198	C++
 	godot.windows.editor.x86_64.exe!predelete_handler(Object * p_object) Line 2027	C++
 	[Inline Frame] godot.windows.editor.x86_64.exe!memdelete(Window * p_class) Line 105	C++
 	godot.windows.editor.x86_64.exe!SceneTree::finalize() Line 628	C++
 	godot.windows.editor.x86_64.exe!widechar_main(int argc, wchar_t * * argv) Line 182	C++
 	godot.windows.editor.x86_64.exe!_main() Line 206	C++
 	godot.windows.editor.x86_64.exe!main(int argc, char * * argv) Line 218	C++
 	[Inline Frame] godot.windows.editor.x86_64.exe!invoke_main() Line 102	C++
 	godot.windows.editor.x86_64.exe!__scrt_common_main_seh() Line 288	C++
 	kernel32.dll!00007ffb57ce257d()	Unknown
 	ntdll.dll!00007ffb58d0aa68()	Unknown

image1
image2

Steps to reproduce

Create a scene, add the AnimationTree, try to press Reload Current Project -> the editor will crash and will not be restarted.

Minimal reproduction project

TestCrash.zip

@Chaosus Chaosus changed the title Hashmap crash when closing the editor with an empty AnimationTree Crash when closing the editor with an empty AnimationTree Sep 30, 2023
@akien-mga akien-mga added this to the 4.2 milestone Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants