Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight rect in "Whole search" is slightly offseted since 4.2.dev1 #83009

Closed
rob1gat opened this issue Oct 8, 2023 · 2 comments · Fixed by #83101
Closed

Highlight rect in "Whole search" is slightly offseted since 4.2.dev1 #83009

rob1gat opened this issue Oct 8, 2023 · 2 comments · Fixed by #83101

Comments

@rob1gat
Copy link

rob1gat commented Oct 8, 2023

Godot version

v4.2.dev1.official [0c2144d]

System information

Godot v4.2.dev1 - Linux Mint 21.1 (Vera) - Vulkan (Forward+) - dedicated AMD Radeon RX 6700 XT (RADV NAVI22) () - 12th Gen Intel(R) Core(TM) i5-12400 (12 Threads)

Issue description

Since 4.2.dev1, the highlight rectangle of the whole search (Ctrl+Maj+F) is slightly offseted to the left :
godot_whole_search_highlight_issue

Issue is still here on 4.2.dev6.

EDIT : Is it related to commit 92287c2 ?

Steps to reproduce

  1. In script editor : Ctrl+Maj+F, then search for a word
  2. See the highlight rectangle

Minimal reproduction project

N/A

@Calinou
Copy link
Member

Calinou commented Oct 10, 2023

I can confirm this on 4.2.dev 42425ba (100% editor scale, default font and font size). I bisected the regression to 670b7be. cc @joao-pedro-braz

EDIT : Is it related to commit 92287c2 ?

That commit is in 4.0-stable, so it would affect 4.1.1 too if that was the cause.

@joao-pedro-braz
Copy link
Contributor

One of my first contributions and it's bugged... way to go lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants