remove_paragraph(0) in RichTextLabel only works once

[TheSofox]

Godot version

80de898

System information

Window 10 - 4.2.rc

Issue description

Calling "remove_paragraph(0)" on a RichTextLabel should remove the first line of text in the label. However, it doesn't seem to work more than once in a row. Even calling "remove_paragraph(1)" actually works better since it always removes the 2nd line even when called repeatedly.

Steps to reproduce

1. Fill a RichTextLabel with several lines of text
2. Call "remove_paragraph(0)" on it multiple times.

Expected:
Each time you call "remove_paragraph(0)", the first line should be deleted.

Actual:
The first line is deleted the first time you call "remove_paragraph(0)", but each subsequent time you do it, nothing happens.

Example project attached makes it easy to test. RichTextLabel has been set up already, along with buttons to call "remove_paragraph" when pressed.

Minimal reproduction project

RichTextRemoveParagraph.zip

[jsjtxietian]

Confirmed. Related to

godot/scene/gui/rich_text_label.cpp

Lines 3389 to 3391 in 80de898

	if (p_paragraph == 0 && current->subitems.size() > 0) {
	main->lines[0].from = main;
	}

Comment them and it works as expected. cc @bruvzg

[nickyfoo]

Not sure if this is possibly related, but I have a PR relating to crashes from RichTextLabel as well

[miv391]

If the RichTextLabel's text property supposed to always return the current content? Now removing paragraphs (any paragraphs, with or without jsjtxietian's fix) doesn't change what text returns. The original content is always returned.

[bruvzg]

If the RichTextLabel's text property supposed to always return the current content? Now removing paragraphs (any paragraphs, with or without jsjtxietian's fix) doesn't change what text returns. The original content is always returned.

get_parsed_text() should return current text, get_text is source text in won't change and not intended to be used with remove_paragraph.

RTL have two ways to set its content:

• bbcode (text property).
• add_*, push_*, pop, remove_paragraph methods.

Mixing both is not supported (setting text will override everything else, and none of the other methods should affect text).