Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to exit out of editor fullscreen mode in Godot 4.2 rc2 #85398

Closed
xxSeys1 opened this issue Nov 26, 2023 · 5 comments · Fixed by #85427
Closed

Unable to exit out of editor fullscreen mode in Godot 4.2 rc2 #85398

xxSeys1 opened this issue Nov 26, 2023 · 5 comments · Fixed by #85427

Comments

@xxSeys1
Copy link

xxSeys1 commented Nov 26, 2023

Godot version

v4.2.rc2.official [1ba920f]

System information

Godot v4.2.rc2 - Windows 10.0.22631 - Vulkan (Forward+) - dedicated AMD Radeon RX 6700 XT (Advanced Micro Devices, Inc.; 31.0.22023.1014) - AMD Ryzen 9 5900X 12-Core Processor (24 Threads)

Issue description

When I enter fullscreen mode in the editor with shift + f11 while being in or then going to the 3D editor, I can't exit it anymore by pressing the same keybind.

Steps to reproduce

Create a new Godot project
Press shift + f11 to enable editor fullscreen
Go to the 3D editor
Try to exit editor fullscreen with shift + f11

Minimal reproduction project

Create a new Godot project

@xxSeys1 xxSeys1 changed the title Unable to exit out of fullscreen mode in Godot 4.3 rc2 Unable to exit out of editor fullscreen mode in Godot 4.3 rc2 Nov 26, 2023
@xxSeys1 xxSeys1 changed the title Unable to exit out of editor fullscreen mode in Godot 4.3 rc2 Unable to exit out of editor fullscreen mode in Godot 4.2 rc2 Nov 26, 2023
@akien-mga
Copy link
Member

akien-mga commented Nov 26, 2023

I can't reproduce on Linux (Mageia 9, KDE/X11) with 4.2-rc2.

Do you have any custom plugin installed that would handle Shift+F11 as a hotkey?
Can you reproduce this issue in previous versions of Godot? (4.1.3, 4.2 dev/beta snapshots).

@Diordany
Copy link

I can't reproduce on Linux (Mageia 9, KDE/X11) with 4.2-rc2.

I also couldn't reproduce this issue on Linux 6.6.2-arch1-1 with KDE/X11 using Godot Engine v4.2.rc2.official [1ba920f].

@xxSeys1
Copy link
Author

xxSeys1 commented Nov 26, 2023

In 4.2 rc1 after trying to disable fullscreen with shift + F11 the window reverts to a small size (about the window size of Godot project manager). This is not because it was in that size before making it fullscreen (before making it fullscreen it was in fullscreen but with window title bar visible).

Beta 6 also behaves this way.

Beta 5 behaves as expected (Editor window return to fullscreen but with window title bar visible)

4.1.3 also behaves as intended (same as Beta 5)

I'm testing this in an empty project so no plugins are there that could take control of shift + f11

UPDATE: 4.2 rc2 now behaves the same way as 4.2 rc1

@akien-mga
Copy link
Member

Thanks for testing, this sounds like a regression from #84504 which was merged for 4.2-beta6. CC @jitspoe @bruvzg

@bruvzg
Copy link
Member

bruvzg commented Nov 27, 2023

I can't reproduce inability to exit full screen.

In 4.2 rc1 after trying to disable fullscreen with shift + F11 the window reverts to a small size (about the window size of Godot project manager). This is not because it was in that size before making it fullscreen (before making it fullscreen it was in fullscreen but with window title bar visible).

This is expected behavior for setting window mode to WINDOW_MODE_WINDOWED (which was fixed by #84504), but I guess editor shortcut should instead save previous mode and restore it to maximized if it was before entering FS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants