Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AnimationPlayer does not get the Discrete key correctly when seeking if there is an precision error #85483

Closed
TokageItLab opened this issue Nov 28, 2023 · 0 comments · Fixed by #85569
Closed

AnimationPlayer does not get the Discrete key correctly when seeking if there is an precision error #85483

TokageItLab opened this issue Nov 28, 2023 · 0 comments · Fixed by #85569
Assignees
@TokageItLab
Labels
bug regression topic:animation
Milestone
4.3

Comments

@TokageItLab
Copy link
Member

TokageItLab commented Nov 28, 2023 •
edited
Loading

Godot version

4.2 RC2

System information

Any

Issue description

AnimationMixer separates the accuracy of how discrete keys are retrieved when seeking between internal seeking and external seeking. FYI: #80708.

Since AnimationPlayer currently treats everything as an internal seek, so it needs to propagate the external seek information.

Steps to reproduce

Seek AnimationTrackEditor

Minimal reproduction project

gd_anim_unittest_1.zip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TokageItLab TokageItLab

Labels
bug regression topic:animation
Projects
None yet
Milestone
4.3
Development

Successfully merging a pull request may close this issue.

Fix AnimationPlayer seeking for Discrete keys TokageItLab/godot
2 participants
@akien-mga @TokageItLab