Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find in files not ignoring folders with .gdignore #85935

Closed
kuruk-mm opened this issue Dec 8, 2023 · 0 comments · Fixed by #85943
Closed

Find in files not ignoring folders with .gdignore #85935

kuruk-mm opened this issue Dec 8, 2023 · 0 comments · Fixed by #85943

Comments

@kuruk-mm
Copy link
Contributor

kuruk-mm commented Dec 8, 2023

Tested versions

Repro in: v4.2.stable.official [46dc277] and v4.1

System information

Linux Mint 21

Issue description

Real case scenario:
After I installed the Android Build Template... and I exported it. The export generates copies of all the GDScript. And they are shown when you try to find them in files.

image

It's annoying for the all days workflow.

Trying to get a solution

I saw that the Android Build Template creates a .gdignore file, that makes all the content ignored by the importer. But it's not working for the Find in files...

I created a minimal reproduction project, with a folder with a .gdignore inside of it.
image

And looks like the .gdignore is not working for Search in files.

In the Godot code, it should be ignored, but looks like it's not working

// If there is a .gdignore file in the directory, skip searching the directory.
if (file == ".gdignore") {
break;
}

Steps to reproduce

(if you open the minimal reproduction project, skip to the step 4)

  1. Create a project
  2. Create a folder with a GDScript in it, the GDScript put a comment # Something to search
  3. Create .gdignore inside the folder that you created
  4. Find in files some # Something to search, and you will see the content of the files that are in a folder with a .gdignore.

Minimal reproduction project (MRP)

MinimalSearchInFiles.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants